pull_requests: 1481454407
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1481454407 | PR_kwDOAMm_X85YTTNH | 8089 | open | 0 | WIP: Factor out a function for checking dimension-related errors | 20118130 | This is a WIP follow-up for #8079 and I think also for #7051. The pattern ```python missing_dims = set(dims) - set(self.dims) if missing_dims: raise ValueError(f"Dimensions {missing_dims} not found in data dimensions {tuple(self.dims)}") ``` occurs in many methods, with small variations in the way `missing_dims` is calculated, the error message, and also if it's `ValueError` or `KeyError`. So it would make sense to factor it out. But I'm not familiar enough with the context around #7051 to know how to deal with sets vs tuples, so this is just a sketch for now. - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` | 2023-08-19T13:35:29Z | 2023-09-12T18:59:32Z | 2e4469509167bef7e158efa291f06ba8e328a636 | 1 | aa6149eaa696c6247a1a18ff7f5066036637015e | 2951ce0215f14a8a79ecd0b5fc73a02a34b9b86b | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/8089 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests