home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 147839851

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
147839851 MDExOlB1bGxSZXF1ZXN0MTQ3ODM5ODUx 1642 closed 0 Fix rasterio backend for rasterio=1.0a10 3585769 - [x] Closes #1641 - [x] Tests added / passed - [x] Passes ``git diff upstream/master | flake8 --diff`` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API First commit should fix rasterio backend for the current alpha release `rasterio=1.0a10` and for future stable releases. Behind the scenes rasterio converts to a `Window` using `Window.from_slices`. I thought about doing the conversion within xarray and passing a `Window` directly, but that would require importing rasterio within the `__getitem__`, which seems not very great. Second commit updates the CI service configurations to use the conda-forge development channel that the rasterio alphas are published on. I put the dev channel behind existing channels, and pinned the version of rasterio to anything `1.0` and beyond. Not so sure what the best course of action here is and I'm happy to take suggestions. Still have to add to the `whats-new`. I'm assuming I can ignore flake8 warnings from the conda environment files (e.g., `git diff upstream/master -- '*.py' | flake8 --diff`)? 2017-10-20T16:15:34Z 2017-10-24T20:53:09Z 2017-10-24T20:53:09Z 2017-10-24T20:53:09Z 583b8e80bfe399144ab4f055ae15a04e58d65a2f     0 0f183beaaaa39877bd53c1241fc91ae4d41a94d9 423d3902ae432989a8a28bf9608621805d7095c5 CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/1642  

Links from other tables

  • 0 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 4.608ms