home / github / pull_requests

Menu
  • GraphQL API
  • Search all tables

pull_requests: 1474103523

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1474103523 PR_kwDOAMm_X85X3Qjj 8069 closed 0 Dataset.chunk() and DataArray.chunk() now set encoding attribute 2466330 <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #8062 - [x] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` This PR aims to fix the bug identified in Issue #8062 , where calling the `.chunk()` function on a `DataArray` or `Dataset` would change the chunking of the underlying data, but not change the `"chunks"` entry in the `encoding` attribute. This would lead to Datasets that cannot be written to file (zarr) without raising an error. The setting of the `encoding` attribute via the `.chunk()` function is part of the expected behavior based on the docstring of `Dataset.to_zarr`: > Zarr chunks are determined in the following way: - From the ``chunks`` attribute in each variable's ``encoding`` (can be set via `Dataset.chunk`). 2023-08-14T09:45:19Z 2023-10-14T20:39:06Z 2023-10-14T20:39:05Z   8df121c78732861c5d991ebe6524588e033cca38     0 17780769a798818782b9413f7460459a4a540b18 f8ab40c5fc1424f9c66206ba9f00dc21735890af CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/8069  

Links from other tables

  • 2 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 0.849ms