home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 145761497

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
145761497 MDExOlB1bGxSZXF1ZXN0MTQ1NzYxNDk3 1622 closed 0 Improved netcdf4 error message when opening non existent file 2443309 - [x] Tests added / passed - [x] Passes ``git diff upstream/master | flake8 --diff`` This is particularly helpful when using `open_mfdataset` with a list of files. For example: Current behavior (unclear which file is causing open_dataset to choke): ```Python-traceback In [2]: xr.open_mfdataset(['foo.nc', 'bar.nc'], engine='netcdf4') --------------------------------------------------------------------------- OSError Traceback (most recent call last) <ipython-input-2-12b24f38f025> in <module>() ----> 1 xr.open_mfdataset(['foo.nc', 'bar.nc'], engine='netcdf4') ... /Users/jhamman/Dropbox/src/xarray/xarray/backends/netCDF4_.py in _open_netcdf4_group(filename, mode, group, **kwargs) 183 import netCDF4 as nc4 184 --> 185 ds = nc4.Dataset(filename, mode=mode, **kwargs) 186 187 with close_on_error(ds): netCDF4/_netCDF4.pyx in netCDF4._netCDF4.Dataset.__init__() netCDF4/_netCDF4.pyx in netCDF4._netCDF4._ensure_nc_success() OSError: No such file or directory ``` And the new behavior ```Python-traceback In [2]: xr.open_mfdataset(['foo.nc', 'bar.nc'], engine='netcdf4') ... /Users/jhamman/Dropbox/src/xarray/xarray/backends/netCDF4_.py in _open_netcdf4_group(filename, mode, group, **kwargs) 186 ds = nc4.Dataset(filename, mode=mode, **kwargs) 187 except OSError as e: --> 188 raise OSError("Error opening %r" % filename, e) 189 190 with close_on_error(ds): OSError: [Errno Error opening '/Users/jhamman/Dropbox/src/xarray/foo.nc'] No such file or directory 2017-10-10T18:03:16Z 2017-10-20T19:35:11Z 2017-10-20T19:35:11Z   6b74f020418e31a52144e1e79359f739af91b947     0 e864567484b2b484ff6c35614289880eb2ce2dd5 b46fcd656391d786b8d25b0615f6d4bd30b524b7 MEMBER   13221727 https://github.com/pydata/xarray/pull/1622  

Links from other tables

  • 2 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 5.172ms