pull_requests: 1457018637

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1457018637 PR_kwDOAMm_X85W2FcN 8034 closed 0 sort when encoding coordinates for deterministic outputs 3383837 - [x] Closes #8026 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - ~~[ ] New functions/methods are listed in `api.rst`~~ The PR changes `conventions._encode_coordinates` to add `sorted` during the creation of "coordinates" strings *de novo*. It does not touch user-specified coordinates attributes or encodings. The PR adds a test, but also changes two pre-existing tests that allowed for non-deterministic ordering of the coordinates string. In reviewing the netCDF data model and CF convenstions, I confirmed that there is no requirement on the ordering of names in the coordinates attribute. I also learned that the global coordinates attribute created by XArray for non-dimension coordinates that are not associated with a variable is not compliant with CF conventions, as was [discussed in 2014](https://mailman.cgd.ucar.edu/pipermail/cf-metadata/2014/007571.html). In 2021, CF-Conventions 1.9 added ["Domain Variables"](http://cfconventions.org/cf-conventions/cf-conventions.html#domain-variables), which appear to provide a CF compliant way to handle this situation. I will likely open an enhancement issue to weigh making that change. 2023-07-31T21:16:31Z 2023-08-03T16:27:28Z 2023-08-03T16:27:27Z 2023-08-03T16:27:27Z fb6bbbecf23aa8052a8c7d93bd5b1eb1eb3ea699     0 a887d83e237e132ee55b9d897f02f397ef46b5de 92c8b33eb464b09d6f8277265b16cae039ab57ee CONTRIBUTOR 
{
    "enabled_by": {
        "login": "dcherian",
        "id": 2448579,
        "node_id": "MDQ6VXNlcjI0NDg1Nzk=",
        "avatar_url": "https://avatars.githubusercontent.com/u/2448579?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/dcherian",
        "html_url": "https://github.com/dcherian",
        "followers_url": "https://api.github.com/users/dcherian/followers",
        "following_url": "https://api.github.com/users/dcherian/following{/other_user}",
        "gists_url": "https://api.github.com/users/dcherian/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/dcherian/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/dcherian/subscriptions",
        "organizations_url": "https://api.github.com/users/dcherian/orgs",
        "repos_url": "https://api.github.com/users/dcherian/repos",
        "events_url": "https://api.github.com/users/dcherian/events{/privacy}",
        "received_events_url": "https://api.github.com/users/dcherian/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "sort when encoding coordinates for deterministic outputs (#8034)",
    "commit_message": "* sort assignments to .attr[\"coordinates\"]\r\n\r\n* [skip-ci] Apply suggestions from code review\r\n\r\nCo-authored-by: Michael Niklas  <mick.niklas@gmail.com>\r\n\r\n---------\r\n\r\nCo-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>\r\nCo-authored-by: Michael Niklas <mick.niklas@gmail.com>"
}
 13221727 https://github.com/pydata/xarray/pull/8034  

Links from other tables