pull_requests: 140604676

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
140604676 MDExOlB1bGxSZXF1ZXN0MTQwNjA0Njc2 1570 closed 0 Support opening password protected datasets over Opendap (Fixes #1068) 3639582 - [x] Closes #1068 - [x] Tests added / passed - [x] Passes ``git diff upstream/master | flake8 --diff`` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API Changed `PydapDataStore` to be initialized with a Pydap dataset (returned by `pydap.client.open_url`). Also added a `open` classmethod to PydapDataStore, for opening with a url. The `open` classmethod also takes an optional session object, allowing the api discussed in #1068: ``` pydap_ds = pydap.client.open_url(url, session=session) store = xarray.backends.PydapDataStore(pydap_ds) ds = xarray.open_dataset(store) ``` or ``` store = xarray.backends.PydapDataStore.open(url, session=session) ds = xarray.open_dataset(store) ``` I tested this with NASA Earthdata as you can see in the added testcase, so i used a session object returned from pydap.cas.urs.setup_session() as that function is tailored for that. However, it just returns a `Session` object from the requests library, so maybe homemade requests sessions can work with other sites. I haven't been able to find other freely accessible but password-protected data repositories. I thought about adding the other keyword parameters from `pydap.client.open_url` to `xarray.backends.PydapDataStore.open` but I was unsure whether that would be a good idea? Also, if we should do it, would it be okay to just pass `**kwargs` on to `pydap.client.open_url`? Any constructive feedback and/or proposed changes are highly welcome of course. By the way, this is my first time contributing to an open source project like this, so please let me know if there is anything I should have done otherwise! 2017-09-12T15:01:02Z 2018-10-11T04:49:50Z 2017-09-15T16:00:05Z 2017-09-15T16:00:05Z 3fb5cbbeabef9d1df538ffa11cb01e6c09ea17a4     0 433b0889f623024e16099be98ab5d87d9b1ee03a ae4df1d8304ccd1eebec2c50e66f1671c1682ef8 CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/1570  

Links from other tables