pull_requests: 1386907083
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1386907083 | PR_kwDOAMm_X85SqoXL | 7905 | open | 0 | Add '.hdf' extension to 'netcdf4' backend | 1828519 | I'm helping @joleenf debug an issue where some old code that uses `xr.open_dataset` no longer works since the introduction of engines or at least as far as we can tell. The main issue is that she's using code that assumes the NetCDF4 C library was compiled with HDF4 support (ex. conda-forge builds with this functionality enabled). So in this case `netCDF4.Dataset("my_file.hdf")` can actually read the HDF4 file through the NetCDF4 C library. However, with `xr.open_dataset("my_file.hdf")` will fail because xarray (or rather the netcdf4 engine) doesn't know that it could potentially read HDF4 files. This PR adds the `.hdf` extension to the 'netcdf4' engine to allow this to be automatic without needing `engine='netcdf4'` to be specified. What do people think? I didn't want to put any more work into this until others weighed in. - [ ] Closes #xxxx - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` | 2023-06-10T00:45:15Z | 2023-06-14T15:25:08Z | 3df1dc60eb0250a11655e15289454b06ba29f86d | 0 | 9abc5ba691bd4200cf1561d31cfd78d6434ce684 | 3459e6fa3c41b9e7b796800682bcf1408467cf1e | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/7905 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests