pull_requests: 1369630754
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1369630754 | PR_kwDOAMm_X85Rougi | 7883 | closed | 0 | Avoid one call to len when getting ndim of Variables | 90008 | I admit this is a super micro optimization but it avoids in certain cases the creation of a tuple, and a call to len on it. I hit this as I was trying to understand why Variable indexing was so much slower than numpy indexing. It seems that bounds checking in python is just slower than in C. Feel free to close this one if you don't want this kind of optimization. <!-- Feel free to remove check-list items aren't relevant to your change --> - [ ] Closes #xxxx - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` | 2023-05-29T23:37:10Z | 2023-07-03T15:44:32Z | 2023-07-03T15:44:31Z | 623aff94a679912d56e5fa38543f20856d368753 | 0 | 856419b0599c024405510cac5fd71ad8c00deca4 | 86f99337d803866a4288fc7550f9ee8c495baf87 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/7883 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests