pull_requests: 136815948
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 136815948 | MDExOlB1bGxSZXF1ZXN0MTM2ODE1OTQ4 | 1514 | closed | 0 | Add `pathlib.Path` support to `open_(mf)dataset` | 5700886 | - [x] Closes #799 - [x] Tests added / passed - [x] Passes ``git diff upstream/master | flake8 --diff`` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API This is meant to eventually make `xarray.open_dataset` and `xarray.open_mfdataset` work with `pathlib.Path` objects. I think this can be achieved as follows: 1. In `xarray.open_dataset`, cast any `pathlib.Path` object to string 2. In `xarray.open_mfdataset`, make sure to handle generators. This is necessary, because `pathlib.Path('some-path').glob()` returns generators. Curently, tests with Python 2 are failing, because there is no explicit `pathlib` dependency yet. With Python 3, everything seems to work. I am not happy with the tests I've added so far, though. | 2017-08-21T18:21:34Z | 2017-09-01T15:31:59Z | 2017-09-01T15:31:52Z | 2017-09-01T15:31:52Z | 4a15cfa6f3e680af6969f3e2c6a375e2cc8c3288 | 0 | 791ba5b2430d45780c0e59b0664892a644f0a7df | 4571d60859850ec121fbaae04d717754f5a35dd1 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/1514 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests