pull_requests: 1365373352
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1365373352 | PR_kwDOAMm_X85RYfGo | 7875 | closed | 0 | defer to `numpy` for the expected result | 14808389 | `numpy` has recently changed the result of `np.cos(0)` by a very small value, which makes our tests break. I'm not really sure what the best fix is, so I split the changes into two parts: the first commit uses ```python xr.testing.assert_allclose(a + 1, np.cos(a)) ``` to test the result, while the second commit uses ```python expected = xr.full_like(a, fill_value=np.cos(0), dtype=float) actual = np.cos(a) xr.testing.assert_identical(actual, expected) ``` - [x] towards #7707 | 2023-05-25T21:48:18Z | 2023-05-27T19:53:08Z | 2023-05-27T19:53:07Z | 2023-05-27T19:53:07Z | fcb81756a1d81f334e84f35e4b6cb59a448e367e | 0 | 7075f0059d0f4c69da209b3a6fc007bec2ae9af1 | f45eb733b97e0a20f2981b6b20e8e8dcc815e529 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/7875 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests