pull_requests: 136113206
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 136113206 | MDExOlB1bGxSZXF1ZXN0MTM2MTEzMjA2 | 1508 | closed | 0 | ENH: Support using opened netCDF4.Dataset (Fixes #1459) | 221526 | Make the filename argument to `NetCDF4DataStore` polymorphic so that a `Dataset` can be passed in. - [x] Closes #1459 - [x] Tests added / passed - [x] Passes ``git diff upstream/master | flake8 --diff`` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API #1459 discussed adding an alternate constructor (i.e. a class method) to `NetCDF4DataStore` to allow this, which would be my preferred approach rather than making a `filename` polymorphic (via `isinstance`). Unfortunately, alternate constructors only work by taking one set of parameters (or setting defaults) and then passing them to the original constructor. Given that, there's no way to make an alternate constructor without also making the original constructor somehow aware of this functionality--or breaking backwards-compatibility. I'm open to suggestions to the contrary. | 2017-08-16T20:19:01Z | 2017-08-31T22:24:36Z | 2017-08-31T17:18:51Z | 2017-08-31T17:18:51Z | b190501a011f3427ae6a3220d72a8d972cb7c203 | 2415632 | 0 | 0e79adcc13dfd6da76a06eca57adda8d18327a33 | 174bad061dc5ac37a4b5e849ad2afa957127745f | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/1508 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests