home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 13607527

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
13607527 MDExOlB1bGxSZXF1ZXN0MTM2MDc1Mjc= 68 closed 0 ENH: More flexible math with variables from different datasets 1217238 PR #33 was definitely a useful change -- item access via [] should return items still in the context of the dataset they were pulled from. However, it doesn't make sense to always keep track of all dataset variables. A particular example is when doing math between variables from different datasets. To be more concrete, suppose I have two datasets ("obs" and "sim"), each with two measurement variables ("tmin" and "tmax"). It should be possible to calculate `obs['tmin'] - sim['tmin']` without a merge conflict due to conflicting values of "tmax". Unfortunately, this is exactly what the current version of xray reports. This PR fixes this behavior, by automatically including only coordinates necessary to describe the arrays involved (via `DatasetArray.select`) when merging datasets resulting from mathematical operations. A possible downside is that occasionally auxiliary coordinates worth keeping around will be lost (e.g., `(2 * obs['tmin']).dataset` no longer contains a variable "tmax"). But on the whole I think this behavior is much more in line with reasonable expectations. This change also removes the DatasetArray methods `refocus` and `unselected` from the public API. I think this is the right call, since these functions were highly specific and really only useful for the prior version of the internal API. 2014-03-15T22:04:09Z 2014-06-12T23:44:33Z 2014-03-24T20:07:46Z 2014-03-24T20:07:46Z 8c57be46a4f394c84657c64d926879f7a6915cd8     0 50c421df2ccfecbf2d1f2f822c879b667f52c992 bb6885d8cc7f7dacdfd4646f6527599076230604 MEMBER   13221727 https://github.com/pydata/xarray/pull/68  

Links from other tables

  • 0 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 1.247ms