pull_requests: 1359566001
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1359566001 | PR_kwDOAMm_X85RCVSx | 7862 | closed | 0 | CF encoding should preserve vlen dtype for empty arrays | 85085 | <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #7328 - [x] Tests added The idea is that it enables a workaround for #7328, where the dtype metadata can be set to a vlen string so that it doesn't get changed to float. The line that is changed in the example in #7328 is: ``` ds = xr.Dataset({"a": np.array([], dtype=coding.strings.create_vlen_dtype(str))}) ``` | 2023-05-22T16:41:11Z | 2023-06-16T07:00:35Z | 2023-06-16T03:56:14Z | 2023-06-16T03:56:14Z | 0c876e4a9e214918b9366b178b2be083cfe8379a | 0 | 334802c85e33e265b4b430fcf9f32cf5cf776490 | 99f95591dcaafb6a5f538700c25a8c52e8a39812 | CONTRIBUTOR | { "enabled_by": { "login": "dcherian", "id": 2448579, "node_id": "MDQ6VXNlcjI0NDg1Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/2448579?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dcherian", "html_url": "https://github.com/dcherian", "followers_url": "https://api.github.com/users/dcherian/followers", "following_url": "https://api.github.com/users/dcherian/following{/other_user}", "gists_url": "https://api.github.com/users/dcherian/gists{/gist_id}", "starred_url": "https://api.github.com/users/dcherian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dcherian/subscriptions", "organizations_url": "https://api.github.com/users/dcherian/orgs", "repos_url": "https://api.github.com/users/dcherian/repos", "events_url": "https://api.github.com/users/dcherian/events{/privacy}", "received_events_url": "https://api.github.com/users/dcherian/received_events", "type": "User", "site_admin": false }, "merge_method": "squash", "commit_title": "CF encoding should preserve vlen dtype for empty arrays (#7862)", "commit_message": "* CF encoding should preserve vlen dtype for empty arrays\r\n\r\n* [pre-commit.ci] auto fixes from pre-commit.com hooks\r\n\r\nfor more information, see https://pre-commit.ci\r\n\r\n* preserve vlen string dtype in netcdf4 and zarr backends\r\n\r\n* check for h5py-variant (\"vlen\") in coding.strings.check_vlen_dtype\r\n\r\n* add test to check preserving vlen dtype for empty vlen string arrays\r\n\r\n* ignore call_overload error for np.dtype(\"O\", metadata={\"vlen\": str})\r\n\r\n* use filter.codec_id instead of private filter._meta as suggested in review\r\n\r\n* update comment and add whats-new.rst entry\r\n\r\n* fix whats-new.rst\r\n\r\n* fix whats-new.rst (missing dot)\r\n\r\n---------\r\n\r\nCo-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>\r\nCo-authored-by: Kai M\u00fchlbauer <kai.muehlbauer@uni-bonn.de>\r\nCo-authored-by: Kai M\u00fchlbauer <kmuehlbauer@wradlib.org>\r\nCo-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>" } |
13221727 | https://github.com/pydata/xarray/pull/7862 |
Links from other tables
- 5 rows from pull_requests_id in labels_pull_requests