pull_requests: 1333121658
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1333121658 | PR_kwDOAMm_X85PddJ6 | 7799 | closed | 0 | Start making unit testing more general | 6197628 | As part of https://github.com/pydata/xarray/issues/525, I would like to start running the same tests already implemented for `pint` on other unit libraries - the one I'm specifically interested in is `astropy`. This PR is a proof of concept to start making the tests in `test_units.py` more general, so it's easy to implement tests against other unit libraries. Important bits of this PR: - The `UnitInfo` base class, which defines an interface against which additional unit libraries can be implemented. - Concrete implementations of this for `pint` and `astropy` (the astropy one is commented out for now) - Modifications that make `test_apply_ufunc_dataarray` run for both `astropy` and `pint`. - A few new tests for helper functions, that I needed to fix issues with `astropy` testing Would be greatful for feedback - is this worthwhile? If so, I can roll this approach out to more tests in `test_units.py` (there's certainly a lot of them!), either in this PR or a subsequent one. | 2023-04-30T18:04:52Z | 2024-01-11T11:49:14Z | 2024-01-11T11:49:14Z | ce373a9cbf4407f64f5ecb736511d46312d516f4 | 0 | 038b3db3491723a9d4eb0c94a9808a1c812b7908 | 1146c5a3cdb15d402e95153c3ea68826b158d953 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/7799 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests