pull_requests: 1321139700
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1321139700 | PR_kwDOAMm_X85Ovv30 | 7771 | closed | 0 | implement scale_factor/add_offset CF conformance test, add and align tests | 5821660 | <!-- Feel free to remove check-list items aren't relevant to your change --> - [ ] Closes #xxxx - [x] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` This is adding conformance tests for `scale_factor`/`add_offset`/`dtype` when encoding/decoding [cf packed data](https://cfconventions.org/Data/cf-conventions/cf-conventions-1.10/cf-conventions.html#packed-data) with https://github.com/pydata/xarray/blob/c75ac8b7ab33be95f74d9e6f10b8173c68828751/xarray/coding/variables.py#L217. This doesn't include tests for `_FillValue`/`missing_value`/`valid_range` etc. which need a separate test. The idea behind is two-fold: - be strict when encoding to only write CF conforming data, raise Errors if non-conforming - be liberal when decoding, but issue warnings This is another step to move forward to finally fix issues like #2304 and a bunch more. | 2023-04-20T09:03:06Z | 2023-11-17T20:59:38Z | 2023-11-17T20:59:38Z | 19353bcfdb1991648e8c84bd0ac809a08e867070 | 1 | 3c745ed959657e5da8e6d4aa66f1e06f0a4e1655 | 2873831e5048fc630b1eaa5b3316d2e876e1afc7 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/7771 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests