pull_requests: 121899206

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
121899206 MDExOlB1bGxSZXF1ZXN0MTIxODk5MjA2 1421 open 0 Adding arbitrary object serialization 2941720 This adds support for object serialization using the netCDF4-python backend.. Minimum working (at least appears to..) example, no tests yet. I added `allow_object` kwarg (rather than `allow_pickle`, no reason to firmly attach pickle to the api, could use something else for other backends). This is now for: - `to_netcdf` - `AbstractDataStore` (a `True` value raises `NotImplementedError` for everything but `NetCDF4DataStore`) - `cf_encoder` which when `True` alters its behaviour to allow `dtype('O')` through. `NetCDF4DataStore` handles this independently from the cf_encoder/decoder. The dtype support made it hard to decouple, plus I think object serialization is a backend dependent issue. There's a lot of potential for refactoring, just pushed this to get opinions about whether this was a reasonable approach - I'm relatively new to open source, so would appreciate any constructive feedback/criticisms! - [ ] Closes #xxxx - [ ] Tests added / passed - [ ] Passes ``git diff upstream/master | flake8 --diff`` - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API ^ these will come later! 2017-05-23T01:59:37Z 2022-06-09T14:50:17Z     e0280d2771d39477920900d0857f248bce5ad87a     0 2b387ca6ef87be0d77ad1d78adf63d9531519f13 d1e4164f3961d7bbb3eb79037e96cae14f7182f8 CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/1421  

Links from other tables