pull_requests: 121071107
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 121071107 | MDExOlB1bGxSZXF1ZXN0MTIxMDcxMTA3 | 1412 | closed | 0 | Multiindex scalar coords, fixes #1408 | 6815844 | - [x] Closes #1408 - [x] Tests added / passed - [x] Passes ``git diff upstream/master | flake8 --diff`` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API To fix #1408, This modification works, but actually I do not fully satisfied yet. There are `if` statements in many places. The major changes I made are 1. `variable.__getitem__` now returns an OrderedDict if a single element is selected from MultiIndex. 2. `indexing.remap_level_indexers` also returns `selected_dims` which is a map from the original dimension to the selected dims which will be a scalar coordinate. Change 1 keeps level-coordinates even after `ds.isel(yx=0)`. Change 2 enables to track which levels are selected, then the selected levels are changed to a scalar coordinate. I guess much smarter solution should exist. I would be happy if anyone gives me a comment. | 2017-05-17T14:25:50Z | 2017-05-25T11:04:55Z | 2017-05-25T11:04:55Z | aace43cba61ca4f45e2ec4e53571d604f77dd0a1 | 0 | 185abd0ed70996fafea5ad23f36d867703b81203 | d5c7e0612e8243c0a716460da0b74315f719f2df | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/1412 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests