pull_requests: 120903269

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
120903269 MDExOlB1bGxSZXF1ZXN0MTIwOTAzMjY5 1411 closed 0 fixed dask prefix naming 1197350 - [x] Closes #1343 - [x] Tests added / passed - [x] Passes ``git diff upstream/master | flake8 --diff`` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API I am starting a new PR for this since the original one (#1345) was not branched of my own fork. As the discussion there stood, @shoyer suggested that `dataset.chunk` should also be updated to match the latest conventions in dask naming. The relevant code is here ```python def maybe_chunk(name, var, chunks): chunks = selkeys(chunks, var.dims) if not chunks: chunks = None if var.ndim > 0: token2 = tokenize(name, token if token else var._data) name2 = '%s%s-%s' % (name_prefix, name, token2) return var.chunk(chunks, name=name2, lock=lock) else: return var variables = OrderedDict([(k, maybe_chunk(k, v, chunks)) for k, v in self.variables.items()]) ``` Currently, `chunk` has an optional keyword argument `name_prefix='xarray-'`. Do we want to keep this optional? IMO, the current naming logic in `chunk` is not a problem for dask and will not cause problems for the distributed bokeh dashboard (as `open_dataset` did). 2017-05-16T19:10:30Z 2017-05-22T20:39:01Z 2017-05-22T20:38:56Z 2017-05-22T20:38:56Z d80248476ebe4a3845211c5d58e0af1effc73ea3     0 630726ad12b9e83094ddd14bd02e6d4d2a18d706 028454d9d8c6d7d2f8afd7d0133941f961dbe231 MEMBER   13221727 https://github.com/pydata/xarray/pull/1411  

Links from other tables