pull_requests: 1199410428
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1199410428 | PR_kwDOAMm_X85HfYz8 | 7444 | closed | 0 | Preserve `base` and `loffset` arguments in `resample` | 6628425 | While pandas is getting set to remove the `base` and `loffset` arguments in `resample`, we have not had a chance to emit a deprecation warning for them yet in xarray (https://github.com/pydata/xarray/issues/7420). This PR preserves their functionality in xarray and should hopefully give users some extra time to adapt. Deprecation warnings for each are added so that we can eventually remove them. I've taken the liberty to define a `TimeResampleGrouper` object, since we need some way to carry the `loffset` argument through the `resample` chain, even though it will no longer be allowed on the `pd.Grouper` object. Currently it is not particularly complicated, so hopefully it would be straightforward to adapt to what is envisioned in https://github.com/pydata/xarray/issues/6610#issuecomment-1341296800. - [x] closes #7266 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` | 2023-01-16T19:16:39Z | 2023-03-08T18:16:12Z | 2023-03-08T16:55:22Z | 2023-03-08T16:55:22Z | 6d771fc82228bdaf8a4b77d0ceec1cc444ebd090 | 0 | d922d713b0e671747fbd55b5d7f51e037d0c59da | 821dc24b5f3ed91b843a634bf8513a26046269ef | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/7444 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests