pull_requests: 1185417960
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1185417960 | PR_kwDOAMm_X85GqAro | 7418 | closed | 0 | Import datatree in xarray? | 35968931 | I want [datatree](https://github.com/xarray-contrib/datatree) to live in xarray main, as right now it's in a separate package but imports many xarray internals. This presents a few questions: 1) At what stage is datatree "ready" to moved in here? At what stage should it become encouraged public API? 2) What's a good way to slowly roll the feature out? 3) How do I decrease the bus factor on datatree's code? Can I get some code reviews during the merging process? :pray: 4) Should I make a new CI environment just for testing datatree stuff? Today @jhamman and @keewis suggested for now I make it so that you can `from xarray import DataTree`, using the current xarray-datatree package as an optional dependency. That way I can create a smoother on-ramp, get some more users testing it, but without committing all the code into this repo yet. @pydata/xarray what do you think? Any other thoughts about best practices when moving a good few thousand lines of code into xarray? - [x] First step towards moving solution of #4118 into this repository - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [x] New functions/methods are listed in `api.rst` | 2023-01-04T20:48:09Z | 2023-12-22T17:38:04Z | 2023-12-22T17:38:04Z | cc8dfe882e7c6962ebe3dd108a9330a8c31d17ad | 0 | 7cf1d5532cbad1aaf9841cbe959e764ad9661835 | 67d0ee20f66517627a2ce795b650b980dd982de9 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/7418 |
Links from other tables
- 4 rows from pull_requests_id in labels_pull_requests