pull_requests: 1172881488
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1172881488 | PR_kwDOAMm_X85F6MBQ | 7395 | closed | 0 | implement `isnull` using `full_like` instead of `zeros_like` | 14808389 | After changing the behavior of the implementation of `*_like` in `pint`, it seems comparisons fail now. As it turns out, this is because we're using `zeros_like` to return all-`False` arrays from `isnull` for input with non-nullable dtypes. I'd argue that ```python full_like(data, dtype=bool, fill_value=False) ``` is a little bit easier to understand than ```python zeros_like(data, dtype=bool) ``` as the latter requires knowledge about the bit representation of `False`, so the change is not *only* to get `pint` to work properly. - [x] Tests added | 2022-12-20T22:07:30Z | 2024-01-28T14:19:26Z | 2024-01-23T18:29:14Z | 2024-01-23T18:29:14Z | d34ebff531b5c02ead95b9dcd9b1c8fdf101260a | 0 | d0c67354dbd29267df839273bcc1289138d6abb6 | d20ba0d387d206a21d878eaf25c8b3392f2453d5 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/7395 |
Links from other tables
- 3 rows from pull_requests_id in labels_pull_requests