pull_requests: 1139443490
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1139443490 | PR_kwDOAMm_X85D6oci | 7334 | closed | 0 | Remove code used to support h5py<2.10.0 | 90008 | It seems that the relevant issue was fixed in 2.10.0 https://github.com/h5py/h5py/commit/466181b178c1b8a5bfa6fb8f217319e021f647e0 I'm not sure how far back you want to fix things. I'm hoping to test this on the CI. I found this since I've been auditing slowdowns in our codebase, which has caused me to review much of the reading pipeline. Do you want to add a test for h5py>=2.10.0? Or can we assume that users won't install things together. https://pypi.org/project/h5py/2.10.0/ I could for example set the backend to not be available if a version of h5py that is too old is detected. One could alternatively, just keep the code here. <!-- Feel free to remove check-list items aren't relevant to your change --> - [ ] Closes #xxxx - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` | 2022-11-29T19:34:24Z | 2022-11-30T23:30:41Z | 2022-11-30T23:30:41Z | 2022-11-30T23:30:41Z | 2fb22cf37b0de6c24ef8eef0f8398d34ee4e3ebb | 0 | 84539d6bba8f4d425b53eecde62e229e4fa84257 | 3aa75c8d00a4a2d4acf10d80f76b937cadb666b7 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/7334 |
Links from other tables
- 3 rows from pull_requests_id in labels_pull_requests