pull_requests: 1120402737

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1120402737 PR_kwDOAMm_X85Cx_0x 7284 closed 0 Enable `origin` and `offset` arguments in `resample` 6628425 This PR enables the `origin` and `offset` arguments in `resample`. This was simple to do in the case of data indexed by a `DatetimeIndex`, but naturally required changes to our internal implementation of `resample` for data indexed by a `CFTimeIndex`. Fortunately those changes were fairly straightforward to port over from pandas. This does not do anything to address the deprecation of `base` noted in #7266, but is an important first step toward getting up to speed with the latest version of pandas, both on the `DatetimeIndex` side and the `CFTimeIndex` side. This way we will at least be able to handle that deprecation in the same way for each. - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` I think things are fairly comprehensively implemented and tested here, but I'm marking this as a draft for now as I want to see if I can reduce the number of cftime resampling tests some, which have multiplied with the addition of these new arguments. 2022-11-13T15:23:01Z 2022-11-29T00:06:46Z 2022-11-28T23:38:52Z 2022-11-28T23:38:52Z 1083c9d3f9ff7b5b03ffb65fa0cf7876c2e73a1a     0 4dbf69482e3f647e7e64f8c17a816ce3970c279e 78b27ecce58c5fe74a75a11c69fd48b5a7a8da61 MEMBER 
{
    "enabled_by": {
        "login": "dcherian",
        "id": 2448579,
        "node_id": "MDQ6VXNlcjI0NDg1Nzk=",
        "avatar_url": "https://avatars.githubusercontent.com/u/2448579?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/dcherian",
        "html_url": "https://github.com/dcherian",
        "followers_url": "https://api.github.com/users/dcherian/followers",
        "following_url": "https://api.github.com/users/dcherian/following{/other_user}",
        "gists_url": "https://api.github.com/users/dcherian/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/dcherian/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/dcherian/subscriptions",
        "organizations_url": "https://api.github.com/users/dcherian/orgs",
        "repos_url": "https://api.github.com/users/dcherian/repos",
        "events_url": "https://api.github.com/users/dcherian/events{/privacy}",
        "received_events_url": "https://api.github.com/users/dcherian/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "Enable `origin` and `offset` arguments in `resample` (#7284)",
    "commit_message": "* Initial work toward enabling origin and offset arguments in resample\r\n\r\n* [pre-commit.ci] auto fixes from pre-commit.com hooks\r\n\r\nfor more information, see https://pre-commit.ci\r\n\r\n* Fix _convert_offset_to_timedelta\r\n\r\n* Reduce number of tests\r\n\r\n* Address initial review comments\r\n\r\n* Add more typing information\r\n\r\n* Make cftime import lazy\r\n\r\n* Fix module_available import and test\r\n\r\n* Remove old origin argument\r\n\r\n* Add type annotations for resample_cftime.py\r\n\r\n* Add None as a possibility for closed and label\r\n\r\n* Add what's new entry\r\n\r\n* Add missing type annotation\r\n\r\n* Delete added line\r\n\r\n* Fix typing errors\r\n\r\n* Add comment and test for as_timedelta stub\r\n\r\n* Remove old code\r\n\r\n* [test-upstream]\r\n\r\nCo-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>\r\nCo-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>"
}
 13221727 https://github.com/pydata/xarray/pull/7284  

Links from other tables