home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 1100227080

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1100227080 PR_kwDOAMm_X85BlCII 7225 closed 0 join together duplicate entries in the text `repr` 14808389 `Indexes` contains one entry per coordinate, even if there are indexes that index multiple coordinates. This deduplicates the entries, but the format is not quite clear. - [x] follow-up to #6795 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` The formatting options we were able to come up with: 1. separate with just newlines (see e29aeb9085bc677e16dabd4a2b94cf63d06c155e): ``` Indexes: one CustomIndex two three PandasIndex ``` 2. mark unique indexes with a prefix to make it look like a list (see 9b90f8bceda6f012c863927865cc638e0ff3fb88): ``` Indexes: - one CustomIndex two - three PandasIndex ``` 3. use unicode box components (in front of the coordinate names) (see 2cec070ebf4f1958d4ffef98d7649eda21ac09a3): ``` Indexes: ┌ one CustomIndex │ two └ three four PandasIndex ``` 4. use unicode box components (after the coordinate names) (see 492ab47ccce8c43d264d5c759841060d33cafe4d): ``` Indexes: one ┐ CustomIndex two │ three ┘ four PandasIndex ``` For the unicode box components, we can choose between the light and heavy variants. @benbovy and I think the unicode variants (especially variant 3) are the easiest to understand, but we would need to decide whether we care about terminals that don't support unicode. Edit: in the meeting we decided that support for the subsection of unicode should be common enough that we can use it. I'll clean this PR up to implement option 3, then. 2022-10-26T12:53:49Z 2023-07-24T18:37:05Z 2023-07-20T21:13:57Z 2023-07-20T21:13:56Z 6b1ff6d13bf360df786500dfa7d62556d23e6df9     0 b07b3376d7a5c46a9d193d600b1f395e368430d4 2bf15f8d29251c94471da89a177814ed09cf8d20 MEMBER   13221727 https://github.com/pydata/xarray/pull/7225  

Links from other tables

  • 2 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 79.256ms