pull_requests: 1099665485
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1099665485 | PR_kwDOAMm_X85Bi5BN | 7222 | closed | 0 | Actually make the fast code path return early for Aligner.align | 90008 | In relation to my other PR. Without this PR  With the early return  <details><summary>Removing the frivolous copy (does not pass tests)</summary>  </details> <details><summary>Code for benchmark</summary> ```python from tqdm import tqdm import xarray as xr from time import perf_counter import numpy as np N = 1000 # Everybody is lazy loading now, so lets force modules to get instantiated dummy_dataset = xr.Dataset() dummy_dataset['a'] = 1 dummy_dataset['b'] = 1 del dummy_dataset time_elapsed = np.zeros(N) dataset = xr.Dataset() # tqdm = iter for i in tqdm(range(N)): time_start = perf_counter() dataset[f"var{i}"] = i time_end = perf_counter() time_elapsed[i] = time_end - time_start # %% from matplotlib import pyplot as plt plt.plot(np.arange(N), time_elapsed * 1E3, label='Time to add one variable') plt.xlabel("Number of existing variables") plt.ylabel("Time to add a variables (ms)") plt.ylim([0, 10]) plt.grid(True) ``` </details> xref: https://github.com/pydata/xarray/pull/7221 <!-- Feel free to remove check-list items aren't relevant to your change --> - [ ] Closes #xxxx - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` | 2022-10-26T01:59:09Z | 2022-10-28T16:22:36Z | 2022-10-28T16:22:35Z | 2022-10-28T16:22:35Z | 65bfa4d10a529f00a9f9b145d1cea402bdae83d0 | 0 | f9e23d49244def9a01687d06e8c5ff26e5d68b9e | 040816a64f52974a79f631c55d920f4b6a4c22ec | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/7222 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests