pull_requests: 1097681533

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1097681533 PR_kwDOAMm_X85BbUp9 7206 closed 0 Save groupby codes after factorizing, pass to flox 2448579 <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #6689, - xref #6610 - [x] Closes #7601 - [x] Tests added This is an alternative to #6689. - There I tried to avoid factorizing in the GroupBy constructor, and passed the `by` variable directly to `flox`. Most GroupBy methods however depend on various steps in `__init__`, so it became messy. - Here I instead preserve factorizing in the constructor and pass the factorized codes to `flox`. This simplifies things a lot. Since we'll want to preserve the "for loop over groups" approach for `GroupBy.map`, we'll need something like this anyway. The large amount of deleted code in `_flox_reduce` here suggests to me that this is the better approach. I think we could also use this to generalize to multiple groupers: - factorize each, - `ravel_muti_index` to generate a singe variable to groupby - apply - reshape to output shape - assign new indices. 2022-10-24T16:00:35Z 2023-03-30T04:36:40Z 2023-03-29T16:28:28Z 2023-03-29T16:28:28Z 0ac5541f12894616f35f63cbc884d8d84bcc07d4     0 7dc79d623e89fcbb70799938dd5d44847bc96b4a 4fc8445e603d3d7a9dbaee27527b7c4c3edd1494 MEMBER 
{
    "enabled_by": {
        "login": "dcherian",
        "id": 2448579,
        "node_id": "MDQ6VXNlcjI0NDg1Nzk=",
        "avatar_url": "https://avatars.githubusercontent.com/u/2448579?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/dcherian",
        "html_url": "https://github.com/dcherian",
        "followers_url": "https://api.github.com/users/dcherian/followers",
        "following_url": "https://api.github.com/users/dcherian/following{/other_user}",
        "gists_url": "https://api.github.com/users/dcherian/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/dcherian/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/dcherian/subscriptions",
        "organizations_url": "https://api.github.com/users/dcherian/orgs",
        "repos_url": "https://api.github.com/users/dcherian/repos",
        "events_url": "https://api.github.com/users/dcherian/events{/privacy}",
        "received_events_url": "https://api.github.com/users/dcherian/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "Save groupby codes after factorizing, pass to flox (#7206)",
    "commit_message": "* Save groupby codes after factorizing\r\n\r\n* Fix tests\r\n\r\n* Fix cftime resampling\r\n\r\n* Fix resampling codes.\r\n\r\n* codes is always a DataArray.\r\n\r\n* cleanup\r\n\r\n* WIP\r\n\r\n* Revert \"WIP\"\r\n\r\nThis reverts commit c9e2a62cc43308f397126e549afc8992049984d3.\r\n\r\n* Fix doctests\r\n\r\n* Fix cftime resampling\r\n\r\nFix cftime resampling\r\n\r\n* Better resampling example code.\r\n\r\n* Fix test.\r\n\r\n* Fix bad merge\r\n\r\n* [pre-commit.ci] auto fixes from pre-commit.com hooks\r\n\r\nfor more information, see https://pre-commit.ci\r\n\r\n* Try fixing some typing\r\n\r\n* Avoid warning\r\n\r\n* Fix typing\r\n\r\n* Add regression  test for #7601\r\n\r\nCloses #7601\r\n\r\n* Cleanup + fix typnig\r\n\r\n* Typing run\r\n\r\n* Fix\r\n\r\n---------\r\n\r\nCo-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>\r\nCo-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>"
}
 13221727 https://github.com/pydata/xarray/pull/7206  

Links from other tables