pull_requests: 1052467823
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1052467823 | PR_kwDOAMm_X84-u2Jv | 7020 | open | 0 | Typing of abstract base classes | 43316012 | This PR adds some typing to several abstract base classes that are used in xarray. Most of it is working, only one major point I could not figure out: What is the type of `NDArrayMixin.array`??? I would appreciate it if someone that has more insight into this would help me. Several minor open points: - What is the return value of `ExplicitlyIndexed.__getitem__` - What is the return value of `ExplicitlyIndexed.transpose` - What is the return value of `AbstractArray.data` - `Variable.values` seems to be able to return scalar values which is incompatible with the `AbstractArray` definition. Overall it seems that typing has helped to find some problems again :) Mypy should fail for tests, I did not adopt them yet, want to solve the outstanding issues first. | 2022-09-11T10:27:01Z | 2023-01-19T10:48:20Z | da54e18595d5c0e5dd9c3e2382a9451447ab2bd8 | 0 | 4bca0f52fa7b180cde95348741c28d08429af2d1 | 80c3e8ecc34961b05c01eb1a0c231f97d595fd07 | COLLABORATOR | 13221727 | https://github.com/pydata/xarray/pull/7020 |
Links from other tables
- 4 rows from pull_requests_id in labels_pull_requests