pull_requests: 1052339012
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1052339012 | PR_kwDOAMm_X84-uWtE | 7019 | closed | 0 | Generalize handling of chunked array types | 35968931 | Initial attempt to get cubed working within xarray, as an alternative to dask. - [x] Closes #6807, at least for the case of cubed - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [x] New functions/methods are listed in `api.rst` - [x] Correct type hints I've added a `manager` kwarg to the `.chunk` methods so you can do `da.chunk(manager="cubed")` to convert to a chunked `cubed.CoreArray`, with the default still being `da.chunk(manager="dask")`. (I couldn't think of a better name than "manager", as "backend" and "executor" are already taken.) ~~At the moment it should work except for an import error that I don't understand, see below.~~ Fro cubed to work at all with this PR we would also need: - [x] Cubed to expose the correct array type consistently https://github.com/tomwhite/cubed/issues/123 - [x] A cubed version of `apply_gufunc` https://github.com/tomwhite/cubed/pull/119 - implemented in https://github.com/tomwhite/cubed/pull/149 :partying_face: To-dos for me on this PR: - [x] Re-route `xarray.apply_ufunc` through `cubed.apply_gufunc` instead of dask's `apply_gufunc` when appropriate, - [x] Add `from_array_kwargs` to opening functions, e.g. `open_zarr`, and `open_dataset`, - [x] Add `from_array_kwargs` to creation functions, such as `full_like`, - [x] Add `store_kwargs` as a way to propagate cubed-specific kwargs when saving `to_zarr`. To complete this project more generally we should also: - [ ] Have `cubed.apply_gufunc` support multiple output arguments https://github.com/tomwhite/cubed/issues/152 - [x] Have a top-level `cubed.unify_chunks` to match `dask.array.core.unify_chunks` - [ ] Write a test suite for wrapping cubed arrays, which would be best done via #6894 - [ ] Generalise `xarray.map_blocks` to work on cubed arrays, ideally by first rewriting xarray's implementation of `map_blocks` to use `dask.array.map_blocks` cc @tomwhite | 2022-09-10T22:02:18Z | 2023-07-24T20:40:29Z | 2023-05-18T17:34:31Z | 2023-05-18T17:34:31Z | 6cd6122ab7850842624bfe40579c5b7dc80185f9 | 0 | c69c56319dfbe84ac5e59b97a497ed8de799905d | 964d350a80fe21d4babf939c108986d5fd90a2cf | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/7019 |
Links from other tables
- 15 rows from pull_requests_id in labels_pull_requests