pull_requests: 1047776643
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1047776643 | PR_kwDOAMm_X84-c82D | 6999 | closed | 0 | Raise UserWarning when rename creates a new dimension coord | 4160723 | <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #6607 - [x] Closes #4107 - [x] Closes #6229 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` Current implemented "fix": raise a `UserWarning` and suggest using `swap_dims` (*) Alternatively, we could: - revert the breaking change (i.e., create the index again) and raise a `DeprecationWarning` instead - raise an error instead of a warning I don't have strong opinions on this, I'm happy to implement another alternative. The downside of reverting the breaking change now is that unfortunately it will introduce a breaking change in the next release., while workarounds are pretty straightforward. (*) from https://github.com/pydata/xarray/issues/6607#issuecomment-1126587818, doing `ds.set_coords(['lon']).rename(x='lon').set_index(lon='lon')` is working too. With #6971, `.set_xindex('lon')` could work as well. | 2022-09-06T16:16:17Z | 2022-12-08T09:38:13Z | 2022-09-27T09:33:40Z | 2022-09-27T09:33:40Z | 45c0a114e2b7b27b83c9618bc05b36afac82183c | 0 | 486f9b876c212cc3f2df7dd1438d1832ce5df03b | 1f4be33365573da19a684dd7f2fc97ace5d28710 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/6999 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests