pull_requests: 1043204734

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1043204734 PR_kwDOAMm_X84-Lgp- 6974 closed 0 Ensure encoding["source"] is available for a pathlib.Path object 15375218 Closes #5888. At the moment if you pass a `Path` object, the `source` will not be encoded in, only if a string is passed in. Given there is already a function to handle this, `_normalize_path`, I've simplified the logic to just run that over the `str/Path` to ensure it is always encoded. <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #5888 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` I'm not sure if this needs including in the `whats-new.rst`. I'm happy to add it if desired. 2022-09-01T04:52:42Z 2023-03-01T19:12:12Z 2022-09-13T07:17:39Z 2022-09-13T07:17:39Z e00e51f42ed382cf22cbbea7e8a8c961f05f9045     0 2bb541b0ce7b2a495bc349fb28c8cec5f6783880 b018442c8dfa3e71ec35e294de69e2011949afec CONTRIBUTOR 
{
    "enabled_by": {
        "login": "mathause",
        "id": 10194086,
        "node_id": "MDQ6VXNlcjEwMTk0MDg2",
        "avatar_url": "https://avatars.githubusercontent.com/u/10194086?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/mathause",
        "html_url": "https://github.com/mathause",
        "followers_url": "https://api.github.com/users/mathause/followers",
        "following_url": "https://api.github.com/users/mathause/following{/other_user}",
        "gists_url": "https://api.github.com/users/mathause/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/mathause/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/mathause/subscriptions",
        "organizations_url": "https://api.github.com/users/mathause/orgs",
        "repos_url": "https://api.github.com/users/mathause/repos",
        "events_url": "https://api.github.com/users/mathause/events{/privacy}",
        "received_events_url": "https://api.github.com/users/mathause/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "Ensure encoding[\"source\"] is available for a pathlib.Path object (#6974)",
    "commit_message": "* Ensure 'source' is encoded even when its a Path\r\n\r\nResolves Issue #5888.\r\n\r\nWith this change, the \"source\" encoding will be stored whether the filename is\r\na string or a Path object.\r\n\r\n* Add a test for encoding source with Path object\r\n\r\n* Update whats-new.rst\r\n\r\n* Ensure only string and Path filenames encode source\r\n\r\nCo-authored-by: Mathias Hauser <mathause@users.noreply.github.com>\r\n\r\n* Update doc/whats-new.rst\r\n\r\n* fix link\r\n\r\nCo-authored-by: Mathias Hauser <mathause@users.noreply.github.com>\r\nCo-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>"
}
 13221727 https://github.com/pydata/xarray/pull/6974  

Links from other tables