pull_requests: 1012321890
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1012321890 | PR_kwDOAMm_X848Vs5i | 6851 | closed | 0 | Fix logic bug - add_offset is in encoding, not attrs. | 145117 | `_pop_to` does a pop operation - it removes the key/value pair. So the line above this change will remove `add_offset` from `attrs` if it exists. The second line then checks for `add_offset` in `attrs` which should always be `False`. This is implemented in #6812 but the work there is significantly more involved (see for example different PR addressing the same problem, #2304), so I'm pulling this fix out and submitting it as its own PR. | 2022-07-29T20:21:47Z | 2022-08-01T18:07:04Z | 2022-08-01T18:07:04Z | 2022-08-01T18:07:04Z | 3c98ec7d96cc4b46664850cc7a40af2bc184fea0 | 0 | 0673c6ae2c71b0cbcaa334a3bb5d96cc1af5afcd | 3f7cc2da33d81e76afbfb82da57143b624b03a88 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/6851 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests