id,node_id,number,state,locked,title,user,body,created_at,updated_at,closed_at,merged_at,merge_commit_sha,assignee,milestone,draft,head,base,author_association,auto_merge,repo,url,merged_by 1333121658,PR_kwDOAMm_X85PddJ6,7799,closed,0,Start making unit testing more general,6197628,"As part of https://github.com/pydata/xarray/issues/525, I would like to start running the same tests already implemented for `pint` on other unit libraries - the one I'm specifically interested in is `astropy`. This PR is a proof of concept to start making the tests in `test_units.py` more general, so it's easy to implement tests against other unit libraries. Important bits of this PR: - The `UnitInfo` base class, which defines an interface against which additional unit libraries can be implemented. - Concrete implementations of this for `pint` and `astropy` (the astropy one is commented out for now) - Modifications that make `test_apply_ufunc_dataarray` run for both `astropy` and `pint`. - A few new tests for helper functions, that I needed to fix issues with `astropy` testing Would be greatful for feedback - is this worthwhile? If so, I can roll this approach out to more tests in `test_units.py` (there's certainly a lot of them!), either in this PR or a subsequent one.",2023-04-30T18:04:52Z,2024-01-11T11:49:14Z,2024-01-11T11:49:14Z,,ce373a9cbf4407f64f5ecb736511d46312d516f4,,,0,038b3db3491723a9d4eb0c94a9808a1c812b7908,1146c5a3cdb15d402e95153c3ea68826b158d953,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/7799, 1333140516,PR_kwDOAMm_X85Pdhwk,7800,closed,0,De-duplicate some unit test paramatrization,6197628,"This removes a lot of duplication in parametrizing the unit testing, by extracting a common decorator into a new file. I had to move the tests to a new sub-folder to get this to work, I hope that's okay?",2023-04-30T19:02:57Z,2024-01-11T11:48:51Z,2024-01-11T11:48:51Z,,52cada1bc6b3150007aa314f3182f138a3f0eeea,,,0,a2b2c77d0f41c3450c49dfc5730e0b085e7bd37a,25d9a28e12141b9b5e4a79454eb76ddd2ee2bc4d,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/7800, 1333869197,PR_kwDOAMm_X85PgTqN,7801,closed,0,Update asv links in contributing guide,6197628,"- `asv` is on PyPI, so install from there instead of the git repo - Update some links that are out of date",2023-05-01T14:16:24Z,2023-05-01T15:53:10Z,2023-05-01T15:13:46Z,2023-05-01T15:13:46Z,eec6f7bad8b478749970eafe71a8a506d8130b5a,,,0,2511d0b132479ea899bb16401788687715961d8c,25d9a28e12141b9b5e4a79454eb76ddd2ee2bc4d,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/7801,