id,node_id,number,state,locked,title,user,body,created_at,updated_at,closed_at,merged_at,merge_commit_sha,assignee,milestone,draft,head,base,author_association,auto_merge,repo,url,merged_by 577425672,MDExOlB1bGxSZXF1ZXN0NTc3NDI1Njcy,4941,closed,0,Use definition of DTypeLike from Numpy if found,548266,"This allows application of numpy ufuncs to DataArrays to typecheck correctly with Numpy 1.20 E.g. without this fix: ``` import xarray as xr import numpy as np def applyufunctodataarray() -> xr.DataArray: a = xr.DataArray(np.array([-1,2,3])) b = np.abs(a) return b ``` will result in: ``` test.py:9: error: Argument 1 to ""__call__"" of ""ufunc"" has incompatible type ""DataArray""; expected ""Union[Union[int, float, complex, str, bytes, generic], Sequence[Union[int, float, complex, str, bytes, generic]], Sequence[Sequence[Any]], _SupportsArray]"" Found 1 error in 1 file (checked 1 source file) ``` While it will type check without issues with this fix. I have not yet documented this or added tests. Please let me know if this change is acceptable and I am happy to do that. - [ ] Tests added - [x] Passes `pre-commit run --all-files` - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` ",2021-02-22T08:06:40Z,2021-02-23T19:31:14Z,2021-02-23T19:20:55Z,2021-02-23T19:20:55Z,348eb481976673ea772bb8424dd2c3c33c0356c2,,,0,35c36b87bb6937c45c4ae6b5564973f89214d216,88c5fd2638cd731fa90014a5b0f376ab190441d7,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/4941, 1540306398,PR_kwDOAMm_X85bzzXe,8268,closed,0,Add extra overload for to_netcdf,548266,"The current signature does not match with pyright if a non-literal bool is passed. This fixes type checking of code like this: ```python import xarray as xr def myfunc(compute: bool) -> None: ds = xr.Dataset() ds.to_netcdf(path=""myfile.nc"", compute=compute) ``` with pyright. See https://github.com/microsoft/pyright/issues/6069 for context. ",2023-10-03T16:15:10Z,2023-12-04T07:04:39Z,2023-12-03T18:24:54Z,2023-12-03T18:24:54Z,b8b7857c9c7980b717fb8f7ae3a1e023a28971d3,,,0,a80e3fde776cf814bb170342e0402aead07f53af,2f0091393d187e26515ce1274a32caf1074415db,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/8268,