id,node_id,number,state,locked,title,user,body,created_at,updated_at,closed_at,merged_at,merge_commit_sha,assignee,milestone,draft,head,base,author_association,auto_merge,repo,url,merged_by
106592251,MDExOlB1bGxSZXF1ZXN0MTA2NTkyMjUx,1272,closed,0,Groupby-like API for resampling,4992424,"This is a work-in-progress to resolve #1269. 

- [x] Basic functionality
- [x] Cleanly deprecate old API 
- [x] New test cases
- [x] Documentation / examples
- [x] ""What's new""

Openly welcome feedback/critiques on how I approached this. Subclassing `Data{Array/set}GroupBy` may not be the best way, but it would be easy enough to re-write the necessary helper functions (just `apply()`, I think) so that we do not need to inherit form them directly. Additional issues I'm working to resolve:

- [x] I tried make sure that calls using the old API won't break by refactoring the old logic to `_resample_immediately()`. This may not be the best approach!
- [x] Similarly, I copied all the original test cases and added the suffix `..._old_api`; these could trivially be placed into their related test cases for the new API.
- [x] BUG: **keep_attrs** is ignored when you call it on methods chained to `Dataset.resample()`. Oddly enough, if I hard-code **keep_attrs=True** inside `reduce_array()` in `DatasetResample::reduce` it works just fine. I haven't figured out where the kwarg is getting lost.
- [x] BUG: Some of the test cases (for instance, `test_resample_old_vs_new_api`) fail because the resampling by calling `self.groupby_cls` ends up not working - it crashes because the group sizes that get computed are not what it expects. Occurs with both new and old API",2017-02-16T19:04:07Z,2017-09-22T16:27:36Z,2017-09-22T16:27:35Z,2017-09-22T16:27:35Z,dc7d733bcc10ce935304d65d03124471661243a3,,2415632,0,5cfba57c9dec5546c8441bb286107e55d048584c,7611ed9b678c4004855856d2ec6dc6eb7ac59123,NONE,,13221727,https://github.com/pydata/xarray/pull/1272,
125510157,MDExOlB1bGxSZXF1ZXN0MTI1NTEwMTU3,1453,closed,0,Automate interpretation of _Unsigned attribute,1325771," - [x] Closes #1444 
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API
",2017-06-14T04:43:02Z,2017-08-04T20:43:22Z,2017-07-28T17:39:04Z,2017-07-28T17:39:04Z,e3e6db5b1bf94fd78c5a1b9d872ea8dcb91a7b9c,,2415632,0,9bec545bfa668765858c707498a38c3663e20519,5d245b22e9500a7eb805193ba5c65bb5474a5ae1,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/1453,
125648831,MDExOlB1bGxSZXF1ZXN0MTI1NjQ4ODMx,1454,closed,0,change NotImplemented to NotImplementedError for h5netcdf autoclose=True,1388357,"Solves this error:

```
TypeError: 'NotImplementedType' object is not callable
```",2017-06-14T17:17:32Z,2017-08-04T20:43:22Z,2017-06-15T00:33:00Z,2017-06-15T00:33:00Z,22ff955d53e253071f6e4fa849e5291d0005282a,,2415632,0,c6b1724c462dcaeb1e900c940c5953e9ffe41a53,aeb4108b1f39cde2bac765ca58c70b5011b188c5,NONE,,13221727,https://github.com/pydata/xarray/pull/1454,
125871748,MDExOlB1bGxSZXF1ZXN0MTI1ODcxNzQ4,1455,closed,0,Add attributes to rasterio backend,2840348,"Adds the 'res', 'is_tiled', and 'transform' attributes to xarray's rasterio backend.

 - [X] Closes #1456
 - [X] Tests added / passed
 - [X] Passes ``git diff upstream/master | flake8 --diff``
 - [X] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

EDIT: fixed typo; 'tiled' attribute name updated to 'is_tiled'",2017-06-15T17:21:45Z,2017-08-04T20:43:22Z,2017-07-01T09:55:31Z,2017-07-01T09:55:31Z,6a20f917041abf53bcb35e210d59f5b331211012,,2415632,0,755057223e1c6564ffac8a727b4ff4a13f4e6e9d,22ff955d53e253071f6e4fa849e5291d0005282a,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/1455,
125936835,MDExOlB1bGxSZXF1ZXN0MTI1OTM2ODM1,1457,closed,0,Feature/benchmark,2443309," - [x] Closes #1257 
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

This is a very bare bones addition of the [asv](https://github.com/spacetelescope/asv/) benchmarking tool to xarray. I have added four very rudimentary benchmarks in the `dataset_io.py` module. 

Usage of `asv` is pretty straightforward but I'll outline the steps for those who want to try this out:
```
cd xarray
conda install asv -c conda-forge
asv run  # this will install some conda environments in ./.asv/envs
asv publish  # this collates the results
asv preview  # this will launch a web server so you can visually compare the tests
```

Before I go any further, I want to get some input from @pydata/xarray on what we want to see in this PR. In previous projects, I have found designing tests after the fact can end up being fairly arbitrary and I want to avoid that if at all possible. I'm guessing that we will want to focus our efforts for now on I/O and dask related performance but how we do that is up for discussion.

cc @shoyer, @rabernat, @MaximilianR, @Zac-HD",2017-06-16T00:11:52Z,2017-11-13T04:09:53Z,2017-07-26T16:17:34Z,2017-07-26T16:17:34Z,96e6e8f7ad8dd493c9d15df2951999c6dd04e8c9,,2415632,0,6c058083bfa7e4e044e50ea7e048c60c35686e22,5d245b22e9500a7eb805193ba5c65bb5474a5ae1,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1457,
128266464,MDExOlB1bGxSZXF1ZXN0MTI4MjY2NDY0,1468,closed,0,Center the coordinates to pixels for rasterio backend,2840348,"Rasterio uses edge-based coordinates, which is a different convention from how xarray treats coordinates (based on description here: http://xarray.pydata.org/en/stable/plotting.html#coordinates). This PR centers them, offsetting by half of the resolution.

 - [X] Tests added / passed
 - [X] Passes ``git diff upstream/master | flake8 --diff``
 ~- [ ] Closes #xxxx~
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

CCing @fmaussion since he may be interested.",2017-06-29T23:13:13Z,2017-08-04T20:43:22Z,2017-07-05T21:30:46Z,2017-07-05T21:30:46Z,b201ff784a9c74dbed3b0b178b01bbea75ae9c85,,2415632,0,aeeef43378997ab40f1b5f1e54930e00ba843946,6a20f917041abf53bcb35e210d59f5b331211012,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/1468,
129588481,MDExOlB1bGxSZXF1ZXN0MTI5NTg4NDgx,1473,closed,0,WIP: indexing with broadcasting,1217238,"- [x] Closes #1444, closes #1436
- [x] Tests added / passed
- [x] Passes git diff master | flake8 --diff
- [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

xref https://github.com/pydata/xarray/issues/974#issuecomment-313977794",2017-07-10T01:49:32Z,2018-02-05T09:42:24Z,2017-10-19T16:52:44Z,,02d5a7fc538bb4bfeabf1d9fc1ad0a4aaf7165d5,,2415632,0,170abc515bfc7112c212032ab8cecd50804acdb6,24643ecee2eab04d0f84c41715d753e829f448e6,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1473,
130153789,MDExOlB1bGxSZXF1ZXN0MTMwMTUzNzg5,1476,closed,0,"Fix text in error message, A leftover from #993",204523,"I've spotted this wrong error message. 
In my opinion this is too small to justify an entry in `whats-new.rst`.",2017-07-12T14:31:33Z,2017-08-04T20:43:22Z,2017-07-12T15:56:50Z,2017-07-12T15:56:50Z,fafc4360aa8ab07ec5aeaf47dea012c01c0034a2,,2415632,0,6a0f281a52bfe920368ea92db7afb4caec2a2b4e,b201ff784a9c74dbed3b0b178b01bbea75ae9c85,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/1476,
130465351,MDExOlB1bGxSZXF1ZXN0MTMwNDY1MzUx,1478,closed,0,Fixes dataset rename bug (GH1477),24376349," - [x] Closes #1477 
 - [x] Tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] added whats-new.rst entry.
",2017-07-13T20:55:04Z,2017-08-04T20:43:23Z,2017-07-16T04:12:47Z,2017-07-16T04:12:47Z,5d245b22e9500a7eb805193ba5c65bb5474a5ae1,,2415632,0,f2f1b4bf48e28921a7859695a37bf0671085b24f,fafc4360aa8ab07ec5aeaf47dea012c01c0034a2,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/1478,
130619619,MDExOlB1bGxSZXF1ZXN0MTMwNjE5NjE5,1479,closed,0,Fix test suite failure in TestDataset.test_sel,1217238,"This is a temporary work around for https://github.com/pandas-dev/pandas/issues/16896, which was introduced by pandas 0.20.3

We can safely revert it after the next pandas release.",2017-07-14T15:55:33Z,2017-08-04T20:43:23Z,2017-07-14T16:31:26Z,2017-07-14T16:31:25Z,726c6a3638ecf95889c541d84e892a106c2f2f92,,2415632,0,19bfd032b27b82d9794d4b57ff01e4905cc91471,fafc4360aa8ab07ec5aeaf47dea012c01c0034a2,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1479,
131816195,MDExOlB1bGxSZXF1ZXN0MTMxODE2MTk1,1485,closed,0,add ISSUE_TEMPLATE for github and xr.show_versions(),2443309," - [x] xref #986
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

This PR adds a new module level function `xr.show_versions()` and a new Github Issue Template to help with debugging user issues. Hopefully, we stop having to ask ""what version of dask are you using?"" Functionality is copied from [pandas](https://github.com/pandas-dev/pandas/blob/e99f56e43ab65710a34440067efe372d5f74280b/pandas/util/_print_versions.py). ",2017-07-21T16:54:29Z,2017-10-28T01:24:08Z,2017-10-28T01:24:02Z,2017-10-28T01:24:02Z,3a995294a99a00a62fb451c8dc3f0c404c8e92f5,,2415632,0,97ee679446ca3941a2ec9098142623d2bba8be2d,63902306176da07cf3db52805f3a90a62e18ad46,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1485,
132375543,MDExOlB1bGxSZXF1ZXN0MTMyMzc1NTQz,1488,closed,0,Fix a bug in assert_allclose where rtol and atol were ignored,1217238," - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

~~This still probably should have a regression test.~~ Done",2017-07-25T20:45:11Z,2017-08-04T20:43:23Z,2017-07-27T19:57:29Z,2017-07-27T19:57:29Z,dbf9307db5ce51ef9e59ccc78387ac7ceda6b1b8,,2415632,0,538a2143b721cf2366c2c5cccdaf4e91e164ec37,d275ad6df25457b53a594953f45b252d14260115,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1488,
132443298,MDExOlB1bGxSZXF1ZXN0MTMyNDQzMjk4,1489,closed,0,lazily load dask arrays to dask data frames by calling to_dask_dataframe ,6181563," - [x] Closes #1093
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

Working towards on a solution for #1462 

Just some stub code for the moment.

Dask dataframes don't appear to support MultiIndex so not sure what to do about that. 
",2017-07-26T06:58:41Z,2017-10-28T00:46:58Z,2017-10-28T00:21:52Z,2017-10-28T00:21:52Z,1436509eee30bae1449f0d98ecf66c9fa3dc2572,,2415632,0,ab8180bf6961dcbd0845eab38712e4ed670ead55,4c3c3328a7ea8269e1411c5119dd0b3d4d972cc4,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/1489,
133082254,MDExOlB1bGxSZXF1ZXN0MTMzMDgyMjU0,1496,closed,0,ENH: three argument version of where,1217238,"Example usage:
```python
>>> a.where(a.x + a.y < 5, -1)
<xarray.DataArray (x: 5, y: 5)>
array([[ 0,  1,  2,  3,  4],
       [ 5,  6,  7,  8, -1],
       [10, 11, 12, -1, -1],
       [15, 16, -1, -1, -1],
       [20, -1, -1, -1, -1]])
Dimensions without coordinates: x, y
```
 - [x] Closes #576
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

CC @MaximilianR ",2017-07-29T06:15:39Z,2017-08-08T17:00:34Z,2017-08-08T17:00:30Z,2017-08-08T17:00:30Z,f9464fd74d49b2d89bf973a810b7e78720304989,,2415632,0,9bda28f9626016e5b382d6a978fdb07474b7218c,e3e6db5b1bf94fd78c5a1b9d872ea8dcb91a7b9c,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1496,
136113206,MDExOlB1bGxSZXF1ZXN0MTM2MTEzMjA2,1508,closed,0,ENH: Support using opened netCDF4.Dataset (Fixes #1459),221526,"Make the filename argument to `NetCDF4DataStore` polymorphic so that a
`Dataset` can be passed in.

 - [x] Closes #1459
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

#1459 discussed adding an alternate constructor (i.e. a class method) to `NetCDF4DataStore` to allow this, which would be my preferred approach rather than making a `filename` polymorphic (via `isinstance`). Unfortunately, alternate constructors only work by taking one set of parameters (or setting defaults) and then passing them to the original constructor. Given that, there's no way to make an alternate constructor without also making the original constructor somehow aware of this functionality--or breaking backwards-compatibility. I'm open to suggestions to the contrary.",2017-08-16T20:19:01Z,2017-08-31T22:24:36Z,2017-08-31T17:18:51Z,2017-08-31T17:18:51Z,b190501a011f3427ae6a3220d72a8d972cb7c203,,2415632,0,0e79adcc13dfd6da76a06eca57adda8d18327a33,174bad061dc5ac37a4b5e849ad2afa957127745f,CONTRIBUTOR,,13221727,https://github.com/pydata/xarray/pull/1508,
137907421,MDExOlB1bGxSZXF1ZXN0MTM3OTA3NDIx,1530,closed,0,Deprecate old  pandas support,6815844," - [x] Closes #1512
 - [x] Tests passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

Explicitly deprecated old pandas (< 0.18) and old numpy (< 1.11) supports.
Some backported functions in `npcompat` are removed because numpy == 1.11 already has them.",2017-08-28T09:40:02Z,2017-11-04T09:51:51Z,2017-08-31T17:25:10Z,2017-08-31T17:25:10Z,0b2424a1813bf1af712780c360a94a5588523adf,,2415632,0,da5c16e98193addd1d856e6772b0f521a66ef209,b190501a011f3427ae6a3220d72a8d972cb7c203,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1530,
137960410,MDExOlB1bGxSZXF1ZXN0MTM3OTYwNDEw,1532,closed,0,Avoid computing dask variables on __repr__ and __getattr__,6213168," - [x] Fixes #1522
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

Stop dataset data vars and non-index dataset/dataarray coords from being loaded by repr() and getattr(). The latter is particularly acute when working in Jupyter, which does a dozen or so getattr() when printing an object.",2017-08-28T14:37:20Z,2017-09-21T22:30:02Z,2017-09-21T20:55:43Z,2017-09-21T20:55:43Z,7611ed9b678c4004855856d2ec6dc6eb7ac59123,,2415632,0,7b1b265f803c0a409501dec711762db5f7eb52af,31921fad66698c167b4fe9049963c8bea3fb33ca,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1532,
138539001,MDExOlB1bGxSZXF1ZXN0MTM4NTM5MDAx,1538,closed,0,Fix/1120,2443309," - [x] Closes #1120
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API
",2017-08-30T22:02:52Z,2017-09-06T00:07:11Z,2017-09-06T00:07:08Z,2017-09-06T00:07:08Z,216bb6720dbe22b67fc6194f4f9525ae0f8924e2,,2415632,0,59039a9213c116821ca0697f2fb5f4a9077a035e,5472fb585b9bfda7b0ce5b54d0182d608199df35,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1538,
139029731,MDExOlB1bGxSZXF1ZXN0MTM5MDI5NzMx,1551,closed,0,Load nonindex coords ahead of concat(),6213168," - [x] Closes #1521
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API",2017-09-02T23:19:03Z,2017-10-09T23:32:50Z,2017-10-09T21:15:31Z,2017-10-09T21:15:31Z,14b5f1ca84b41696b7e8e3ec5e07d8064acc9a55,,2415632,0,2f80cef14d0ede182e9521c096f37f88a4e69488,772f7e0564430169afcd1afb4ae869bcc0f9d0c9,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1551,
145599310,MDExOlB1bGxSZXF1ZXN0MTQ1NTk5MzEw,1619,closed,0,Expose apply_ufunc as public API and add documentation,1217238,"`apply_ufunc()` does not meet all our needs for wrapping unlabeled array routines with xarray (see #1618 for a proposal for `apply_raw()`), but it should be useful for many advanced users and isn't doing much in its current state as non-public API. So I'd like to make it public for the xarray 0.10 release.

 - [x] Closes #770
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API
 - [x] Turn the example from #1517 into a separate docs page of some sort, and link to it from `computation.rst` and `dask.rst`.

@MaximilianR @rabernat @jhamman Review from any of you would be appreciated here!",2017-10-10T04:54:11Z,2017-10-20T16:44:51Z,2017-10-20T16:44:47Z,2017-10-20T16:44:47Z,b3387cb178a8ec79fad0252589b865ff3c21cee2,,2415632,0,03754f9f2a150137951e8798a619dfe269e2e868,57ccf4250542e07409f8528b67fa487a0fe84552,MEMBER,,13221727,https://github.com/pydata/xarray/pull/1619,