https://github.com/pydata/xarray/blame/404a6e268d3d83e8bad04768971ba1bc207a155d/doc/user-guide/reshaping.rst#L7

Even though it is a complete sentence, it is missing a period, and probably should be expanded. Or just removed if it's not going to say anything beyond the title ("Reshaping and reorganizing data").

Feature request

I think it would be nice to be able to configure (as a runtime option or somesuch) the behavior of the plotting methods if an ax is not passed. In settings like the Jupyter Notebook, I would prefer a new figure to be created automatically. I realize that you can achieve this by passing figure size kwargs like figsize, but it would be nice if you didn't have to.

Or, is there an easy way to runtime patch xarray.plot.utils.get_axis or another function to achieve this?

What happened?

error: Argument "encoding" to "to_netcdf" of "Dataset" has incompatible type "Dict[str, Dict[str, int]]"; expected "Optional[Mapping[Hashable, Mapping[str, Any]]]" Those sound compatible to me, so I am a bit confused.

I am using something like python encoding = {"variable_name": {"zlib": True, "complevel": 5}} ds.to_netcdf(..., encoding=encoding)

What did you expect to happen?

No response

Minimal Complete Verifiable Example

No response

MVCE confirmation

• [ ] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
• [ ] Complete example — the example is self-contained, including all data and the text of any traceback.
• [ ] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
• [X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output

No response

Anything else we need to know?

No response

Environment

mypy 0.982, xarray 2022.10.0

• [x] Closes #6935
• [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

It does accept it. Should be documented here:

https://github.com/pydata/xarray/blob/59c4752df33d2d08ec47352fc8143a72eb1d9c79/xarray/core/dataset.py#L4733-L4746

Can just be taken from xr.merge():

https://github.com/pydata/xarray/blob/59c4752df33d2d08ec47352fc8143a72eb1d9c79/xarray/core/merge.py#L799-L811

What happened?

This is kind of a convoluted example, but something I ran into. It appears that in certain cases .swap_dims() can modify the original object, here the .dims of a data variable that was swapped into being a dimension coordinate variable.

What did you expect to happen?

I expected it not to modify the original object.

Minimal Complete Verifiable Example

```Python import numpy as np import xarray as xr

nz = 11 ds = xr.Dataset( data_vars={ "y": ("z", np.random.rand(nz)), "lev": ("z", np.arange(nz) * 10), # ^ We want this to be a dimension coordinate }, ) print(f"ds\n{ds}") print(f"\nds, 'lev' -> dim coord\n{ds.swap_dims(z='lev')}")

ds2 = ( ds.swap_dims(z="lev") .rename_dims(lev="z") .reset_index("lev") .reset_coords() ) print(f"\nds2\n{ds2}")

^ This Dataset appears same as the original

print(f"\nds2, 'lev' -> dim coord\n{ds2.swap_dims(z='lev')}")

^ Produces a Dataset with dimension coordinate 'lev'

print(f"\nds2 after .swap_dims() applied\n{ds2}")

^ ds2['lev'] now has dimension 'lev' although otherwise same

```

MVCE confirmation

• [X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
• [X] Complete example — the example is self-contained, including all data and the text of any traceback.
• [X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
• [X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output

No response

Anything else we need to know?

More experiments in this Gist.

Environment

What happened?

Looks like the intention is for the text to be all italic, but where the source breaks it is not working.

Here: https://github.com/pydata/xarray/blame/708204370ef168f35f250ca75e666246ae1420f6/doc/api.rst#L289-L295

(https -> http), which seems not ideal

Updating readme and user-facing docs according to https://github.com/pydata/xarray/issues/1306 (final comment)

• [ ] Passes pre-commit run --all-files
• [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

Notes: * I didn't yet change the contributing page, since it seems to have its own convention (though not used everywhere): xarray (bold and lowercase). * I mostly didn't touch internal docs pages / docstrings. * Also modified some cases of NumPy, pandas, and Dask according to their conventions, but could do more there, especially with NumPy.

While working on the plot method docstrings (#5285), I (and @keewis) found that the colors kwarg for the Dataset plot methods is not as useful as it could be. In some cases it is silently ignored (warning or error could be raised instead).

For Dataset.plot.scatter, I think it would make sense for a list of colors to be able to be passed to be used for discrete hue_style. Currently, the only way you can control these for discrete hue_style is if hue is numeric and you also pass levels.

• [x] Passes pre-commit run --all-files
• [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Summary: * use code-literal style for variables (arguments) and other Python identifiers * fix some type specifications * add more references where helpful * italic for x and y when talking about axes, like in math * correct a bit of grammar stuff * tell which Matplotlib function is being wrapped at the top * capitalize Matplotlib when referring to the library in general, since that is how they do it in their docs, like xarray is lowercase unless starting the sentence * ~~remove ax from the signature of the _dsplot functions (unlike the _plot2d ones, it shows in the built docs)~~ (save for later PR, so can do deprec. cycle because users might have been using ax positionally) * fix matplotlib colormap name Napoleon type alias * remove unused u and v from signature of Dataset.scatter

• [x] Passes pre-commit run --all-files
• [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

Summary: * Add FacetGrid.add_quiverkey to api.rst * Other edits similar to #5285