issues

Table actions

2 rows where type = "pull" and user = 5948670 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

state 2

type 1

  • pull · 2 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
523893854 MDExOlB1bGxSZXF1ZXN0MzQxNzkwMzY2 3544 Open dataset cf options conflict solving MeraX 5948670 open 0     0 2019-11-16T20:43:39Z 2022-06-09T14:50:17Z   CONTRIBUTOR   0 pydata/xarray/pulls/3544

It took some time*, but here is a suggestion to solve option conflicts in xarray.open_dataset().

If any of the options mask_and_scale, decode_times, concat_characters, or decode_coords is manually set and contradicts the manually set choice of decode_cf a ValueError will be raised. This commit requires to change some option default values of open_dataset() parameters from True to None. I hope this is acceptable.

  • [x] Closes #3020
  • [x] Tests added
  • [x] Passes black . && flake8 (mypypasses in principle, but backends/api.py:21 has an unrelated error)
  • [x] Fully documented,
  • [ ] including whats-new.rst for all changes and api.rst for new API

What do you think? Do I have to add something to whats-new.rst and api.rst?

PS: (*) This is my first PR of this kind and I wanted to build it in a proper testing environment, but I had to set this up first.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3544/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
564033048 MDExOlB1bGxSZXF1ZXN0Mzc0MzM1Mzc0 3766 Allow plotting bool data MeraX 5948670 closed 0     0 2020-02-12T14:22:11Z 2020-04-03T23:19:23Z 2020-04-03T23:19:23Z CONTRIBUTOR   0 pydata/xarray/pulls/3766

as @dcherian said:

matplotlib can plot bool values so we should add that to the check in _ensure_plottable.

  • [x] Closes #3722 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3766/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);