issues

Table actions

2 rows where type = "pull" and user = 3383837 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 2 ✖

state 1

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1830038411 PR_kwDOAMm_X85W2FcN 8034 sort when encoding coordinates for deterministic outputs itcarroll 3383837 closed 0     0 2023-07-31T21:16:31Z 2023-08-03T16:27:28Z 2023-08-03T16:27:27Z CONTRIBUTOR   0 pydata/xarray/pulls/8034
  • [x] Closes #8026
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • ~~[ ] New functions/methods are listed in api.rst~~

The PR changes conventions._encode_coordinates to add sorted during the creation of "coordinates" strings de novo. It does not touch user-specified coordinates attributes or encodings.

The PR adds a test, but also changes two pre-existing tests that allowed for non-deterministic ordering of the coordinates string.

In reviewing the netCDF data model and CF convenstions, I confirmed that there is no requirement on the ordering of names in the coordinates attribute. I also learned that the global coordinates attribute created by XArray for non-dimension coordinates that are not associated with a variable is not compliant with CF conventions, as was discussed in 2014. In 2021, CF-Conventions 1.9 added "Domain Variables", which appear to provide a CF compliant way to handle this situation. I will likely open an enhancement issue to weigh making that change.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8034/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1503973868 PR_kwDOAMm_X85F1kOI 7393 Preserve original dtype when accessing MultiIndex levels itcarroll 3383837 closed 0     1 2022-12-20T04:34:24Z 2022-12-24T04:37:45Z 2022-12-24T00:07:42Z CONTRIBUTOR   0 pydata/xarray/pulls/7393
  • [x] Closes #7250
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Just what @benbovy said to do in #7250. Thank you!

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7393/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);