issues

Table actions

2 rows where type = "pull" and user = 1700203 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 2 ✖

state 1

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
434502234 MDExOlB1bGxSZXF1ZXN0MjcxNDgyMjgw 2905 Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute blsqr 1700203 closed 0     8 2019-04-17T21:52:37Z 2021-02-18T17:22:16Z 2021-02-18T15:04:14Z CONTRIBUTOR   0 pydata/xarray/pulls/2905

This change was prompted by the fact that getattr(data, 'values', data) affected any kind of data with a values attribute, which is not the desired behaviour for core.variable.as_compatible_data.

This also extends tests to assert that custom objects with such an attribute are not attempted to be converted.

I'm happy to write additional tests, if you could briefly sketch further requirements.

  • [x] Implemented the changes
  • [x] Closes #2097
  • [x] Tests added
    • [ ] Sufficient?
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2905/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
610687463 MDExOlB1bGxSZXF1ZXN0NDEyMDgxMDE4 4018 Add NetCDF3 dtype coercion for unsigned integer types blsqr 1700203 closed 0     7 2020-05-01T10:38:45Z 2020-07-13T15:37:51Z 2020-05-20T17:08:24Z CONTRIBUTOR   0 pydata/xarray/pulls/4018

This PR addresses #4014.

  • [x] Closes #4014
  • [x] Tests added or adjusted
  • [x] Adjusted a test case where int64 coercion played a role
  • [x] Explicit test for failing coercion (seems to be missing currently -- should this be added?)
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [x] Fully documented
  • [x] Adjusted whats-new.rst for all changes ~~and api.rst for new API~~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4018/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);