issues

Table actions

3 rows where type = "pull", "updated_at" is on date 2022-06-04 and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: comments, created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 3 ✖

state 1

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1243123406 PR_kwDOAMm_X844MH4t 6624 CFTime support for polyval headtr1ck 43316012 closed 0     7 2022-05-20T13:04:46Z 2022-06-04T10:18:14Z 2022-05-31T17:16:04Z COLLABORATOR   0 pydata/xarray/pulls/6624
  • [x] Closes #6623
  • [x] Tests added
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6624/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1251511305 PR_kwDOAMm_X844nz8j 6651 Typing support for custom backends headtr1ck 43316012 closed 0     4 2022-05-28T07:28:41Z 2022-06-04T10:17:55Z 2022-05-28T10:29:16Z COLLABORATOR   0 pydata/xarray/pulls/6651
  • [x] Closes #6632

So far we have not found a good way of typing dynamically added custom backends (installed via pip). So the only fallback option is to allow str.

I have decided to leave the Literal as type, since it gives the user a nice list of supported backends in the editor.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6651/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1260041574 PR_kwDOAMm_X845E39t 6661 Typing of Dataset headtr1ck 43316012 closed 0     4 2022-06-03T15:22:24Z 2022-06-04T10:17:48Z 2022-06-04T04:26:03Z COLLABORATOR   0 pydata/xarray/pulls/6661
  • [x] Closes #5945
  • [x] Tests added

Feel free to wait with merging after the 2022.05.0.dev0 release :)

  • This PR adds typing to all Dataset methods (only the ones in Dataset directly and DataWithCoords).
  • On the way it fixes several typing issues and adds small code changes for more consistent typing (hopefully does not break anything).
  • All test_dataset tests are now typed.
  • As usual there are still some mypy bugs open that prevent all typing changes to be final (especially https://github.com/python/mypy/issues/12846). I choose to remove the TypeVars in these occasions to prevent false positives on the user side.
  • Sorry for updating so many files at once, mostly these are the changes of adding from __future__ import annotations and automatic fixes from pyupdate.

If anyone has some typing expertise: I think that the way align is typed is wrong. The current implementation only works for aligning a sequence of objects of the same type, but not mixed DataArrays and Datasets. In some placed I had to add some "#type: ignore"s... I should probably open an issue for that.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6661/reactions",
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 3,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);