issues

Table actions

3 rows where state = "closed" and user = 72647856 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: comments, body, created_at (date), updated_at (date), closed_at (date)

type 2

state 1

  • closed · 3 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1093467156 I_kwDOAMm_X85BLPwU 6136 DataArray.from_dict: convert docstring code to doctest code-review-doctor 72647856 closed 0     6 2022-01-04T15:28:56Z 2022-02-28T09:11:02Z 2022-02-28T09:11:02Z CONTRIBUTOR      

What happened?

This test is passing in a str for dims: https://github.com/pydata/xarray/blob/60754fdbc4ecd9eb3c0978e82635c6d43e8d485b/xarray/tests/test_dataarray.py#L3074-L3078

dims should be a tuple. I suspect the intent was to specify d = {"dims": ("t",)} when the test was written.

This is small issue, but tests that call functions using the kind of data that would be used in "live" will improve quality of tests. Would be a shame for bug to affect users because tests use a str while in userspace a tuple is used.

What did you expect to happen?

code to be d = {"dims": ("t",)}

Minimal Complete Verifiable Example

No response

Relevant log output

No response

Anything else we need to know?

I'm happy to make a PR to fix this

Environment

NA

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6136/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed xarray 13221727 issue
1094321778 PR_kwDOAMm_X84wjwtW 6140 Remove paren from DataArray.from_dict docstring code-review-doctor 72647856 closed 0     1 2022-01-05T12:54:02Z 2022-01-05T18:15:05Z 2022-01-05T18:14:55Z CONTRIBUTOR   0 pydata/xarray/pulls/6140 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6140/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1093828024 PR_kwDOAMm_X84wiLQ8 6139 remove paren from data that is fed to 1D DataArray code-review-doctor 72647856 closed 0     1 2022-01-04T23:14:28Z 2022-01-05T13:01:59Z 2022-01-05T09:37:38Z CONTRIBUTOR   0 pydata/xarray/pulls/6139 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6139/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);