issues

Problem description

This is a problem if I want to swap_dims in DataArray Accessor.

Code Sample

This is what I'm forced to do: ```python import xarray as xr import numpy as np @xr.register_dataarray_accessor('testing') class TestAccessor(object): def init(self, xarray_obj): self._obj = xarray_obj def the_problem(self): self._obj = self._obj.swap_dims({'x':'x2'}) print(self._obj)

arr = np.random.rand(4,3,2) cube = xr.DataArray(arr, dims=['ya', 'x', 'y'], coords={'y':[1,3], 'ya':[1,2,3,6], 'x':[1,2,5]}) cube.coords['x2'] = ('x', [1,2,3]) cube.testing.the_problem() print(cube) this prints: <xarray.DataArray (ya: 4, x2: 3, y: 2)> array([[[ 0.659583, 0.167555], [ 0.357974, 0.46081 ], [ 0.85115 , 0.845257]],

   [[ 0.280308,  0.777399],
    [ 0.512527,  0.542036],
    [ 0.838603,  0.799414]],

   [[ 0.572031,  0.350464],
    [ 0.205219,  0.812232],
    [ 0.687778,  0.984928]],

   [[ 0.803385,  0.63981 ],
    [ 0.089909,  0.499857],
    [ 0.25266 ,  0.967909]]])

Coordinates: * y (y) int32 1 3 * ya (ya) int32 1 2 3 6 x (x2) int32 1 2 5 * x2 (x2) int32 1 2 3 <xarray.DataArray (ya: 4, x: 3, y: 2)> array([[[ 0.659583, 0.167555], [ 0.357974, 0.46081 ], [ 0.85115 , 0.845257]],

   [[ 0.280308,  0.777399],
    [ 0.512527,  0.542036],
    [ 0.838603,  0.799414]],

   [[ 0.572031,  0.350464],
    [ 0.205219,  0.812232],
    [ 0.687778,  0.984928]],

   [[ 0.803385,  0.63981 ],
    [ 0.089909,  0.499857],
    [ 0.25266 ,  0.967909]]])

Coordinates: * y (y) int32 1 3 * ya (ya) int32 1 2 3 6 * x (x) int32 1 2 5 x2 (x) int32 1 2 3 ``` where the two xarrays are clearly different.

I would want to do: ```python import xarray as xr import numpy as np @xr.register_dataarray_accessor('testing') class TestAccessor(object): def init(self, xarray_obj): self._obj = xarray_obj def the_problem(self): self._obj.swap_dims({'x':'x2'}, inplace = True) print(self._obj)

arr = np.random.rand(4,3,2) cube = xr.DataArray(arr, dims=['ya', 'x', 'y'], coords={'y':[1,3], 'ya':[1,2,3,6], 'x':[1,2,5]}) cube.coords['x2'] = ('x', [1,2,3]) cube.testing.the_problem() print(cube) this would keep the two xarrays the same, as they should be: <xarray.DataArray (ya: 4, x2: 3, y: 2)> array([[[ 0.659583, 0.167555], [ 0.357974, 0.46081 ], [ 0.85115 , 0.845257]],

   [[ 0.280308,  0.777399],
    [ 0.512527,  0.542036],
    [ 0.838603,  0.799414]],

   [[ 0.572031,  0.350464],
    [ 0.205219,  0.812232],
    [ 0.687778,  0.984928]],

   [[ 0.803385,  0.63981 ],
    [ 0.089909,  0.499857],
    [ 0.25266 ,  0.967909]]])

Coordinates: * y (y) int32 1 3 * ya (ya) int32 1 2 3 6 x (x2) int32 1 2 5 * x2 (x2) int32 1 2 3 <xarray.DataArray (ya: 4, x: 3, y: 2)> array([[[ 0.659583, 0.167555], [ 0.357974, 0.46081 ], [ 0.85115 , 0.845257]],

   [[ 0.280308,  0.777399],
    [ 0.512527,  0.542036],
    [ 0.838603,  0.799414]],

   [[ 0.572031,  0.350464],
    [ 0.205219,  0.812232],
    [ 0.687778,  0.984928]],

   [[ 0.803385,  0.63981 ],
    [ 0.089909,  0.499857],
    [ 0.25266 ,  0.967909]]])

Coordinates: * y (y) int32 1 3 * ya (ya) int32 1 2 3 6 x (x2) int32 1 2 5 * x2 (x2) int32 1 2 3 ```

I have version 0.10.0, the newest on conda-forge.

open_rasterio does not work when rasterio crs is None. It is also clearly visible from the code that this is the case: Here's the code from line 144 onward python attrs = {}` if hasattr(riods, 'crs'): # CRS is a dict-like object specific to rasterio # We convert it back to a PROJ4 string using rasterio itself attrs['crs'] = riods.crs.to_string() if hasattr(riods, 'res'): # (width, height) tuple of pixels in units of CRS attrs['res'] = riods.res if hasattr(riods, 'is_tiled'): # Is the TIF tiled? (bool) # We cast it to an int for netCDF compatibility attrs['is_tiled'] = np.uint8(riods.is_tiled) if hasattr(riods, 'transform'): # Affine transformation matrix (tuple of floats) # Describes coefficients mapping pixel coordinates to CRS attrs['transform'] = tuple(riods.transform)`

I have version 1.0a9 for rasterio and 0.9.6 for xarray. For what I looked, the issue #1466 is related, but not same issue.

CRS is None when I read ENVI-dataset that has no georeferencing with rasterio.

Made this fix for the issue #1520. I simpy added a test for None in the code and tested it with my ENVI-file that caused the problem that I reported.

If I understood the test report correctly, the tests also passed.

• [x] Closes #1520
• [x] Tests passed
• [x] Passes git diff upstream/master | flake8 --diff
• [x] Fully documented, including whats-new.rst for all changes and api.rst for new API