issues

Table actions

369 rows where state = "closed", type = "pull" and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: comments, draft, created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 369 ✖

state 1

  • closed · 369 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
2272299822 PR_kwDOAMm_X85uL82a 8989 Skip flaky `test_open_mfdataset_manyfiles` test max-sixty 5635139 closed 0     0 2024-04-30T19:24:41Z 2024-04-30T20:27:04Z 2024-04-30T19:46:34Z MEMBER   0 pydata/xarray/pulls/8989

Don't just xfail, and not only on windows, since it can crash the worker

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8989/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2271670475 PR_kwDOAMm_X85uJ5Er 8988 Remove `.drop` warning allow max-sixty 5635139 closed 0     0 2024-04-30T14:39:35Z 2024-04-30T19:26:17Z 2024-04-30T19:26:16Z MEMBER   0 pydata/xarray/pulls/8988   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8988/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2271652603 PR_kwDOAMm_X85uJ122 8987 Add notes on when to add ignores to warnings max-sixty 5635139 closed 0     0 2024-04-30T14:34:52Z 2024-04-30T14:56:47Z 2024-04-30T14:56:46Z MEMBER   0 pydata/xarray/pulls/8987   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8987/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2268058661 PR_kwDOAMm_X85t9f5f 8982 Switch all methods to `dim` max-sixty 5635139 closed 0     0 2024-04-29T03:42:34Z 2024-04-29T18:24:56Z 2024-04-29T18:24:55Z MEMBER   0 pydata/xarray/pulls/8982

I think this is the final set of methods

  • [x] Closes #6646
  • [ ] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8982/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2267810980 PR_kwDOAMm_X85t8q4s 8981 Enable ffill for datetimes max-sixty 5635139 closed 0     5 2024-04-28T20:53:18Z 2024-04-29T18:09:48Z 2024-04-28T23:02:11Z MEMBER   0 pydata/xarray/pulls/8981

Notes inline. Would fix #4587

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8981/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2262478932 PR_kwDOAMm_X85tqpUi 8974 Raise errors on new warnings from within xarray max-sixty 5635139 closed 0     2 2024-04-25T01:50:48Z 2024-04-29T12:18:42Z 2024-04-29T02:50:21Z MEMBER   0 pydata/xarray/pulls/8974

Notes are inline.

Done with some help from an LLM — quite good for doing tedious tasks that we otherwise wouldn't want to do — can paste in all the warnings output and get a decent start on rules for exclusions

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8974/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1997537503 PR_kwDOAMm_X85fqp3A 8459 Check for aligned chunks when writing to existing variables max-sixty 5635139 closed 0     5 2023-11-16T18:56:06Z 2024-04-29T03:05:36Z 2024-03-29T14:35:50Z MEMBER   0 pydata/xarray/pulls/8459

While I don't feel super confident that this is designed to protect against any bugs, it does solve the immediate problem in #8371, by hoisting the encoding check above the code that runs for only new variables. The encoding check is somewhat implicit, so this was an easy thing to miss prior.

  • [x] Closes #8371,
  • [x] Closes #8882
  • [x] Closes #8876
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8459/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2244681150 PR_kwDOAMm_X85suxIl 8947 Add mypy to dev dependencies max-sixty 5635139 closed 0     0 2024-04-15T21:39:19Z 2024-04-17T16:39:23Z 2024-04-17T16:39:22Z MEMBER   0 pydata/xarray/pulls/8947   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8947/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2128692061 PR_kwDOAMm_X85mkDqu 8735 Remove fsspec exclusion from 2021 max-sixty 5635139 closed 0     1 2024-02-10T19:43:14Z 2024-02-11T00:19:30Z 2024-02-11T00:19:29Z MEMBER   0 pydata/xarray/pulls/8735

Presumably no longer needed

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8735/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2128687154 PR_kwDOAMm_X85mkCum 8734 Silence dask doctest warning max-sixty 5635139 closed 0     0 2024-02-10T19:25:47Z 2024-02-10T23:44:24Z 2024-02-10T23:44:24Z MEMBER   0 pydata/xarray/pulls/8734

Closes #8732. Not the most elegant implementation but it's only temporary

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8734/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2126095122 PR_kwDOAMm_X85mbRG7 8724 Switch `.dt` to raise an `AttributeError` max-sixty 5635139 closed 0     0 2024-02-08T21:26:06Z 2024-02-09T02:21:47Z 2024-02-09T02:21:46Z MEMBER   0 pydata/xarray/pulls/8724

Discussion at #8718

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8724/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2099077744 PR_kwDOAMm_X85k_vqU 8661 Add `dev` dependencies to `pyproject.toml` max-sixty 5635139 closed 0     1 2024-01-24T20:48:55Z 2024-01-25T06:24:37Z 2024-01-25T06:24:36Z MEMBER   0 pydata/xarray/pulls/8661   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8661/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2097231358 PR_kwDOAMm_X85k5dSd 8648 xfail another test on windows max-sixty 5635139 closed 0     0 2024-01-24T01:04:01Z 2024-01-24T01:23:26Z 2024-01-24T01:23:26Z MEMBER   0 pydata/xarray/pulls/8648

As ever, very open to approaches to fix these. But unless we can fix them, xfailing them seems like the most reasonable solution

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8648/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2089331658 PR_kwDOAMm_X85keyUs 8624 Use ddof in `numbagg>=0.7.0` for aggregations max-sixty 5635139 closed 0     0 2024-01-19T00:23:15Z 2024-01-23T02:25:39Z 2024-01-23T02:25:38Z MEMBER   0 pydata/xarray/pulls/8624   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8624/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2094956413 PR_kwDOAMm_X85kxwAk 8643 xfail zarr test on Windows max-sixty 5635139 closed 0     0 2024-01-22T23:24:12Z 2024-01-23T00:40:29Z 2024-01-23T00:40:28Z MEMBER   0 pydata/xarray/pulls/8643

I see this failing quite a lot of the time...

Ofc open to a proper solution but in the meantime setting this to xfail

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8643/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2092299525 PR_kwDOAMm_X85kozmg 8630 Use `T_DataArray` in `Weighted` max-sixty 5635139 closed 0     0 2024-01-21T01:18:14Z 2024-01-22T04:28:07Z 2024-01-22T04:28:07Z MEMBER   0 pydata/xarray/pulls/8630

Allows subtypes.

(I had this in my git stash, so commiting it...)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8630/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2092855603 PR_kwDOAMm_X85kqlH4 8639 Silence deprecation warning from `.dims` in tests max-sixty 5635139 closed 0     1 2024-01-22T00:25:07Z 2024-01-22T02:04:54Z 2024-01-22T02:04:53Z MEMBER   0 pydata/xarray/pulls/8639   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8639/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2092790802 PR_kwDOAMm_X85kqX8y 8637 xfail a cftime test max-sixty 5635139 closed 0     0 2024-01-21T21:43:59Z 2024-01-21T22:00:59Z 2024-01-21T22:00:58Z MEMBER   0 pydata/xarray/pulls/8637 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8637/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2092777417 PR_kwDOAMm_X85kqVIH 8636 xfail another dask/pyarrow test max-sixty 5635139 closed 0     1 2024-01-21T21:26:19Z 2024-01-21T21:42:22Z 2024-01-21T21:42:21Z MEMBER   0 pydata/xarray/pulls/8636

Unsure why this wasn't showing prior -- having tests fail in the good state does make it much more difficult to ensure everything is fixed before merging.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8636/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2089351473 PR_kwDOAMm_X85ke2qd 8625 Don't show stdlib paths for `user_level_warnings` max-sixty 5635139 closed 0     0 2024-01-19T00:45:14Z 2024-01-21T21:08:40Z 2024-01-21T21:08:39Z MEMBER   0 pydata/xarray/pulls/8625

Was previously seeing:

<frozen _collections_abc>:801: FutureWarning: The return type of `Dataset.dims` will be changed to return a set of dimension names in future, in order to be more consistent with `DataArray.dims`. To access a mapping from dimension names to lengths, please use `Dataset.sizes`.

Now:

/Users/maximilian/workspace/xarray/xarray/tests/test_dataset.py:701: FutureWarning: The return type of `Dataset.dims` will be changed to return a set of dimension names in future, in order to be more consistent with `DataArray.dims`. To access a mapping from dimension names to lengths, please use `Dataset.sizes`. assert ds.dims == ds.sizes

It's a heuristic, so not perfect, but I think very likely to be accurate. Any contrary cases very welcome...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8625/reactions",
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2092762468 PR_kwDOAMm_X85kqSLW 8635 xfail pyarrow test max-sixty 5635139 closed 0     0 2024-01-21T20:42:50Z 2024-01-21T21:03:35Z 2024-01-21T21:03:34Z MEMBER   0 pydata/xarray/pulls/8635

Sorry for the repeated PR -- some tests passed but some failed without pyarrow installed. So this xfails the test for the moment

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8635/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2092747686 PR_kwDOAMm_X85kqPTB 8634 Workaround broken test from pyarrow max-sixty 5635139 closed 0     0 2024-01-21T20:01:51Z 2024-01-21T20:18:23Z 2024-01-21T20:18:22Z MEMBER   0 pydata/xarray/pulls/8634

While fixing the previous issue, I introduced another (but didn't see it because of the errors from the test suite, probably should have looked closer...)

This doesn't fix the behavior, but I think it's minor so fine to push off. I do prioritize getting the tests where pass vs failure is meaningful again

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8634/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2092300888 PR_kwDOAMm_X85koz3r 8631 Partially fix doctests max-sixty 5635139 closed 0     1 2024-01-21T01:25:02Z 2024-01-21T01:33:43Z 2024-01-21T01:31:46Z MEMBER   0 pydata/xarray/pulls/8631

Currently getting a error without pyarrow in CI: https://github.com/pydata/xarray/actions/runs/7577666145/job/20693665924

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8631/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2033367994 PR_kwDOAMm_X85hj9np 8533 Offer a fixture for unifying DataArray & Dataset tests max-sixty 5635139 closed 0     2 2023-12-08T22:06:28Z 2023-12-18T21:30:41Z 2023-12-18T21:30:40Z MEMBER   0 pydata/xarray/pulls/8533

Some tests are literally copy & pasted between DataArray & Dataset tests. This change allows them to use a single test. Not everything will be able to use this — sometimes we want to check specifics — but some will — I've change the .cumulative tests to use this fixture.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8533/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2034575163 PR_kwDOAMm_X85hn4Pn 8539 Filter out doctest warning max-sixty 5635139 closed 0     11 2023-12-10T23:11:36Z 2023-12-12T06:37:54Z 2023-12-11T21:00:01Z MEMBER   0 pydata/xarray/pulls/8539

Trying to fix #8537. Not sure it'll work and can't test locally so seeing if it passes CI

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8539/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2036491126 PR_kwDOAMm_X85hud-m 8543 Fix incorrect indent max-sixty 5635139 closed 0     0 2023-12-11T20:41:32Z 2023-12-11T20:43:26Z 2023-12-11T20:43:09Z MEMBER   0 pydata/xarray/pulls/8543

edit: my mistake, this is intended

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8543/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2022202767 PR_kwDOAMm_X85g97hj 8512 Add Cumulative aggregation max-sixty 5635139 closed 0     1 2023-12-02T21:03:13Z 2023-12-08T22:06:53Z 2023-12-08T22:06:52Z MEMBER   0 pydata/xarray/pulls/8512

Closes #5215

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8512/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1410303926 PR_kwDOAMm_X85A3Xqk 7163 Add `eval` method to Dataset max-sixty 5635139 closed 0     3 2022-10-15T22:12:23Z 2023-12-06T17:52:47Z 2023-12-06T17:52:46Z MEMBER   0 pydata/xarray/pulls/7163

This needs proper tests & docs, but would this be a good idea?

A couple of examples are in the docstring. It's mostly just deferring to pandas' excellent eval method.

  • [x] Closes #6440 (edit)
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7163/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
     xarray 13221727 pull
2019309352 PR_kwDOAMm_X85g0KvI 8493 Use numbagg for `rolling` methods max-sixty 5635139 closed 0     3 2023-11-30T18:52:08Z 2023-12-05T19:08:32Z 2023-12-05T19:08:31Z MEMBER   0 pydata/xarray/pulls/8493

A couple of tests are failing for the multi-dimensional case, which I'll fix before merge.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8493/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2019577432 PR_kwDOAMm_X85g1F3A 8495 Fix type of `.assign_coords` max-sixty 5635139 closed 0     1 2023-11-30T21:57:58Z 2023-12-04T19:11:57Z 2023-12-04T19:11:55Z MEMBER   0 pydata/xarray/pulls/8495

As discussed in #8455

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8495/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2022178394 PR_kwDOAMm_X85g92vo 8511 Allow callables to `.drop_vars` max-sixty 5635139 closed 0     0 2023-12-02T19:39:53Z 2023-12-03T22:04:53Z 2023-12-03T22:04:52Z MEMBER   0 pydata/xarray/pulls/8511

This can be used as a nice more general alternative to .drop_indexes or .reset_coords(drop=True)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8511/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2021810083 PR_kwDOAMm_X85g8r6c 8508 Implement `np.clip` as `__array_function__` max-sixty 5635139 closed 0     2 2023-12-02T02:20:11Z 2023-12-03T05:27:38Z 2023-12-03T05:27:33Z MEMBER   0 pydata/xarray/pulls/8508

Would close https://github.com/pydata/xarray/issues/2570

Because of https://numpy.org/neps/nep-0018-array-function-protocol.html#partial-implementation-of-numpy-s-api, no option is ideal: - Don't do anything — don't implement __array_function__. Any numpy function that's not a ufunc — such as np.clip will materialize the array into memory. - Implement __array_function__ and lose the ability to call any non-ufunc-numpy-func that we don't explicitly configure here. So np.lexsort(da) wouldn't work, for example; and users would have to run np.lexsort(da.values). - Implement __array_function__, and attempt to handle the functions we don't explicitly configure by coercing to numpy arrays. This requires writing code to walk a tree of objects looking for arrays to coerce. It seems to go against the original numpy proposal.

@shoyer is this summary accurate?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8508/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2019642778 PR_kwDOAMm_X85g1URY 8497 Fully deprecate `.drop` max-sixty 5635139 closed 0     0 2023-11-30T22:54:57Z 2023-12-02T05:52:50Z 2023-12-02T05:52:49Z MEMBER   0 pydata/xarray/pulls/8497

I think it's time...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8497/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2013544848 PR_kwDOAMm_X85ggbU0 8487 Start renaming `dims` to `dim` max-sixty 5635139 closed 0     1 2023-11-28T03:25:40Z 2023-11-28T21:04:49Z 2023-11-28T21:04:48Z MEMBER   0 pydata/xarray/pulls/8487

Begins the process of #6646. I don't think it's feasible / enjoyable to do this for everything at once, so I would suggest we do it gradually, while keeping the warnings quite quiet, so by the time we convert to louder warnings, users can do a find/replace easily.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8487/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2010795504 PR_kwDOAMm_X85gXOqo 8484 Fix Zarr region transpose max-sixty 5635139 closed 0     3 2023-11-25T21:01:28Z 2023-11-27T20:56:57Z 2023-11-27T20:56:56Z MEMBER   0 pydata/xarray/pulls/8484

This wasn't working on an unregion-ed write; I think because new_var was being lost.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8484/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2010797682 PR_kwDOAMm_X85gXPEM 8485 Refine rolling_exp error messages max-sixty 5635139 closed 0     0 2023-11-25T21:09:52Z 2023-11-25T21:55:20Z 2023-11-25T21:55:20Z MEMBER   0 pydata/xarray/pulls/8485

(Sorry, copy & pasted too liberally!)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8485/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1966733834 PR_kwDOAMm_X85eCSac 8389 Use numbagg for `ffill` by default max-sixty 5635139 closed 0     5 2023-10-28T20:40:13Z 2023-11-25T21:06:10Z 2023-11-25T21:06:09Z MEMBER   0 pydata/xarray/pulls/8389

The main perf advantage here is the array doesn't need to be unstacked & stacked, which is a huge win for large multi-dimensional arrays... (I actually was hitting a memory issue running an ffill on my own, and so thought I'd get this done!)

We could move these methods to DataWithCoords, since they're almost the same implementation between a DataArray & Dataset, and exactly the same for numbagg's implementation

For transparency — the logic of "check for numbagg, check for bottleneck" I wouldn't rate at my most confident. But I'm more confident that just installing numbagg will work. And if that works well enough, we could consider only supporting numbagg for some of these in the future.

I also haven't done the benchmarks here — though the functions are relatively well benchmarked at numbagg. I'm somewhat trading off getting through these (rolling functions are coming up too) vs. doing fewer slower, and leaning towards the former, but feedback welcome...

  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8389/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1964877168 PR_kwDOAMm_X85d8EmN 8381 Allow writing to zarr with differently ordered dims max-sixty 5635139 closed 0     2 2023-10-27T06:47:59Z 2023-11-25T21:02:20Z 2023-11-15T18:09:08Z MEMBER   0 pydata/xarray/pulls/8381

Is this reasonable?

  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8381/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2005419839 PR_kwDOAMm_X85gFPfF 8474 Improve "variable not found" error message max-sixty 5635139 closed 0     0 2023-11-22T01:52:47Z 2023-11-24T18:49:39Z 2023-11-24T18:49:38Z MEMBER   0 pydata/xarray/pulls/8474

One very small step as part of https://github.com/pydata/xarray/issues/8264.

The existing error is just KeyError: 'foo, which is annoyingly terse. Future improvements include searching for similar variable names, or even rewriting the user's calling code if there's a close variable name.

This PR creates a new test file. I don't love the format here — it's difficult to snapshot an error message, so it requires copying & pasting things, which doesn't scale well, and the traceback contains environment-specific lines such that it wouldn't be feasible to paste tracebacks.

(here's what we do in PRQL, which is (immodestly) great)

An alternative is just to put these in the mix of all the other tests; am open to that (and not difficult to change later)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8474/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2006891782 PR_kwDOAMm_X85gKSKW 8478 Add whatsnew for #8475 max-sixty 5635139 closed 0     0 2023-11-22T18:22:19Z 2023-11-22T18:45:23Z 2023-11-22T18:45:22Z MEMBER   0 pydata/xarray/pulls/8478

Sorry, forgot in the original PR

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8478/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2005656379 PR_kwDOAMm_X85gGCSj 8475 Allow `rank` to run on dask arrays max-sixty 5635139 closed 0     0 2023-11-22T06:22:44Z 2023-11-22T16:45:03Z 2023-11-22T16:45:02Z MEMBER   0 pydata/xarray/pulls/8475
  • [x] Tests added
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8475/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2005744975 PR_kwDOAMm_X85gGVaY 8476 Fix mypy tests max-sixty 5635139 closed 0     0 2023-11-22T07:36:43Z 2023-11-22T08:01:13Z 2023-11-22T08:01:12Z MEMBER   0 pydata/xarray/pulls/8476

I was seeing an error in #8475

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8476/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2000139267 PR_kwDOAMm_X85fzghA 8464 Fix `map_blocks` docs' formatting max-sixty 5635139 closed 0     1 2023-11-18T01:18:02Z 2023-11-21T18:25:16Z 2023-11-21T18:25:15Z MEMBER   0 pydata/xarray/pulls/8464

Was looking funky. Not 100% sure this is correct but seems consistent with the others

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8464/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2000146978 PR_kwDOAMm_X85fziKs 8465 Consolidate `_get_alpha` func max-sixty 5635139 closed 0     0 2023-11-18T01:37:25Z 2023-11-21T18:24:52Z 2023-11-21T18:24:51Z MEMBER   0 pydata/xarray/pulls/8465

Am changing this a bit so starting with consolidating it rather than converting twice

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8465/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
400444797 MDExOlB1bGxSZXF1ZXN0MjQ1NjMwOTUx 2687 Enable resampling on PeriodIndex max-sixty 5635139 closed 0     2 2019-01-17T20:13:25Z 2023-11-17T20:38:44Z 2023-11-17T20:38:44Z MEMBER   0 pydata/xarray/pulls/2687

This allows resampling with PeriodIndex objects by keeping the group as an index rather than coercing to a DataArray (which coerces any non-native types to objects)

I'm still getting one failure around the name of the IndexVariable still being __resample_dim__ after resample, but wanted to socialize the approach of allowing a name argument to IndexVariable - is this reasonable?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2687/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1986758555 PR_kwDOAMm_X85fGE95 8438 Rename `to_array` to `to_dataarray` max-sixty 5635139 closed 0     2 2023-11-10T02:58:21Z 2023-11-10T06:15:03Z 2023-11-10T06:15:02Z MEMBER   0 pydata/xarray/pulls/8438

This is a very minor nit, so I'm not sure it's worth changing.

What do others think?

(I would have opened an issue but it's just as quick to just do the PR)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8438/reactions",
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1952859208 PR_kwDOAMm_X85dTmUR 8341 Deprecate tuples of chunks? max-sixty 5635139 closed 0     1 2023-10-19T18:44:25Z 2023-10-21T01:45:28Z 2023-10-21T00:49:19Z MEMBER   0 pydata/xarray/pulls/8341

(I was planning on putting an issue in, but then thought it wasn't much more difficult to make the PR. But it's totally fine if we don't think this is a good idea...)

Allowing a tuple of dims means we're reliant on dimension order, which we really try and not be reliant on. It also makes the type signature even more complicated.

So are we OK to encourage a dict of dim: chunksize, rather than a tuple of chunksizes?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8341/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1953143391 PR_kwDOAMm_X85dUk-m 8347 2023.10.1 release notes max-sixty 5635139 closed 0     0 2023-10-19T22:19:43Z 2023-10-19T22:42:48Z 2023-10-19T22:42:47Z MEMBER   0 pydata/xarray/pulls/8347   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8347/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1948037836 PR_kwDOAMm_X85dDNka 8325 internal: Improve version handling for numbagg max-sixty 5635139 closed 0     1 2023-10-17T18:45:43Z 2023-10-19T15:59:15Z 2023-10-19T15:59:14Z MEMBER   0 pydata/xarray/pulls/8325

Uses the approach in #8316, a bit nicer. Only internal.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8325/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1948548087 PR_kwDOAMm_X85dE9ga 8329 Request to adjust pyright config max-sixty 5635139 closed 0     3 2023-10-18T01:04:00Z 2023-10-18T20:10:42Z 2023-10-18T20:10:41Z MEMBER   0 pydata/xarray/pulls/8329

Would it be possible to not have this config? It overrides the local VS Code config, and means VS Code constantly is reporting errors for me.

Totally open to other approaches ofc. Or that we decide that the tradeoff is worthwhile

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8329/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1948529004 PR_kwDOAMm_X85dE5aA 8327 Add docs to `reindex_like` re broadcasting max-sixty 5635139 closed 0     0 2023-10-18T00:46:52Z 2023-10-18T18:16:43Z 2023-10-18T16:51:12Z MEMBER   0 pydata/xarray/pulls/8327

This wasn't clear to me so I added some examples & a reference to broadcast_like

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8327/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1943054301 PR_kwDOAMm_X85cyrdc 8307 Add `corr`, `cov`, `std` & `var` to `.rolling_exp` max-sixty 5635139 closed 0     0 2023-10-14T07:25:31Z 2023-10-18T17:35:35Z 2023-10-18T16:55:35Z MEMBER   0 pydata/xarray/pulls/8307

From the new routines in numbagg.

Maybe needs better tests (though these are quite heavily tested in numbagg), docs, and potentially need to think about types (maybe existing binary ops can help here?)

(will fail while the build is cached on an old version of numbagg)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8307/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1948537810 PR_kwDOAMm_X85dE7Te 8328 Refine curvefit doctest max-sixty 5635139 closed 0     0 2023-10-18T00:55:16Z 2023-10-18T01:19:27Z 2023-10-18T01:19:26Z MEMBER   0 pydata/xarray/pulls/8328

A very small change

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8328/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1946081841 PR_kwDOAMm_X85c8kKB 8321 Remove a couple of trailing commas in tests max-sixty 5635139 closed 0     0 2023-10-16T20:57:04Z 2023-10-16T21:26:50Z 2023-10-16T21:26:49Z MEMBER   0 pydata/xarray/pulls/8321   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8321/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1920172346 PR_kwDOAMm_X85blZOk 8256 Accept `lambda` for `other` param max-sixty 5635139 closed 0     0 2023-09-30T08:24:36Z 2023-10-14T07:26:28Z 2023-09-30T18:50:33Z MEMBER   0 pydata/xarray/pulls/8256   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8256/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1931467868 PR_kwDOAMm_X85cLSzK 8283 Ask bug reporters to confirm they're using a recent version of xarray max-sixty 5635139 closed 0     0 2023-10-07T19:07:17Z 2023-10-14T07:26:28Z 2023-10-09T13:30:03Z MEMBER   0 pydata/xarray/pulls/8283   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8283/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1931584082 PR_kwDOAMm_X85cLpuZ 8286 Fix `GroupBy` import max-sixty 5635139 closed 0     0 2023-10-08T01:15:37Z 2023-10-14T07:26:28Z 2023-10-09T13:38:44Z MEMBER   0 pydata/xarray/pulls/8286

Not sure why this only breaks tests for me, vs. in CI, but hopefully no downside to this change...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8286/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1931581491 PR_kwDOAMm_X85cLpMS 8284 Enable `.rolling_exp` to work on dask arrays max-sixty 5635139 closed 0     0 2023-10-08T01:06:04Z 2023-10-14T07:26:27Z 2023-10-10T06:37:20Z MEMBER   0 pydata/xarray/pulls/8284

Another benefit of the move to .apply_ufunc...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8284/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1931582554 PR_kwDOAMm_X85cLpap 8285 Add `min_weight` param to `rolling_exp` functions max-sixty 5635139 closed 0     2 2023-10-08T01:09:59Z 2023-10-14T07:24:48Z 2023-10-14T07:24:48Z MEMBER   0 pydata/xarray/pulls/8285   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8285/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1939241220 PR_kwDOAMm_X85cmBPP 8296 mypy 1.6.0 passing max-sixty 5635139 closed 0     4 2023-10-12T06:04:46Z 2023-10-12T22:13:18Z 2023-10-12T19:06:13Z MEMBER   0 pydata/xarray/pulls/8296

I did the easy things, but will need help for the final couple on _typed_ops.py

Because we don't pin mypy (should we?), this blocks other PRs if we gate them on mypy passing

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8296/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1940614908 PR_kwDOAMm_X85cqvBb 8299 xfail flaky test max-sixty 5635139 closed 0     0 2023-10-12T19:03:59Z 2023-10-12T22:00:51Z 2023-10-12T22:00:47Z MEMBER   0 pydata/xarray/pulls/8299

Would be better to fix it, but in lieu of fixing, better to skip it

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8299/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1920359276 PR_kwDOAMm_X85bl9er 8257 Mandate kwargs on `to_zarr` max-sixty 5635139 closed 0     0 2023-09-30T18:33:13Z 2023-10-12T18:33:15Z 2023-10-04T19:05:02Z MEMBER   0 pydata/xarray/pulls/8257

This aleviates some of the dangers of having these in a different order between da & ds.

Technically it's a breaking change, but only very technically, given that I would wager literally no one has a dozen positional arguments to this method. So I think it's OK.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8257/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1926810300 PR_kwDOAMm_X85b7rlX 8273 Allow a function in `.sortby` method max-sixty 5635139 closed 0     0 2023-10-04T19:04:03Z 2023-10-12T18:33:14Z 2023-10-06T03:35:22Z MEMBER   0 pydata/xarray/pulls/8273   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8273/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1931585098 PR_kwDOAMm_X85cLp7r 8287 Rename `reset_encoding` to `drop_encoding` max-sixty 5635139 closed 0     1 2023-10-08T01:19:25Z 2023-10-12T17:11:07Z 2023-10-12T17:11:03Z MEMBER   0 pydata/xarray/pulls/8287

Closes #8259

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8287/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1917929597 PR_kwDOAMm_X85bd2nm 8249 Refine `chunks=None` handling max-sixty 5635139 closed 0     0 2023-09-28T16:54:59Z 2023-10-04T18:34:27Z 2023-09-28T20:01:13Z MEMBER   0 pydata/xarray/pulls/8249

Based on comment in https://github.com/pydata/xarray/pull/8247. This doesn't make it perfect, but allows the warning to get hit and clarifies the type comment, as a stop-gap

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8249/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1916391948 PR_kwDOAMm_X85bYlaM 8242 Add modules to `check-untyped` max-sixty 5635139 closed 0     2 2023-09-27T21:56:45Z 2023-09-29T17:43:07Z 2023-09-29T16:39:34Z MEMBER   0 pydata/xarray/pulls/8242

In reviewing https://github.com/pydata/xarray/pull/8241, I realize that we actually want check-untyped-defs, which is a bit less strict, but lets us add some more modules on. I did have to add a couple of ignores, think it's a reasonable tradeoff to add big modules like computation on.

Errors with this enabled are actual type errors, not just mypy pedanticness, so would be good to get as much as possible into this list...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8242/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1878288525 PR_kwDOAMm_X85ZYos5 8139 Fix pandas' `interpolate(fill_value=)` error max-sixty 5635139 closed 0     6 2023-09-02T02:41:45Z 2023-09-28T16:48:51Z 2023-09-04T18:05:14Z MEMBER   0 pydata/xarray/pulls/8139

Pandas no longer has a fill_value parameter for interpolate.

Weirdly I wasn't getting this locally, on pandas 2.1.0, only in CI on https://github.com/pydata/xarray/actions/runs/6054400455/job/16431747966?pr=8138.

Removing it passes locally, let's see whether this works in CI

Would close #8125 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8139/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1459938761 PR_kwDOAMm_X85DdsG- 7311 Add numba to nightly upstream max-sixty 5635139 closed 0     2 2022-11-22T14:04:54Z 2023-09-28T16:48:16Z 2023-01-15T18:07:48Z MEMBER   0 pydata/xarray/pulls/7311

I saw that we didn't have this while investigating https://github.com/numba/numba/issues/8615. We should probably wait until that's resolved before merging this (this doesn't solve that issue).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7311/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1249095540 PR_kwDOAMm_X844f0MK 6638 Improve perf of xr.corr max-sixty 5635139 closed 0     1 2022-05-26T04:49:27Z 2023-09-28T16:47:12Z 2022-05-26T22:02:06Z MEMBER   0 pydata/xarray/pulls/6638

I think this should improve the performance of xr.corr & xr.cov, but I'm not sure about dask arrays. I haven't been able to do tests on them, but I can do that soon unless anyone has an a priori view.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6638/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1917767929 PR_kwDOAMm_X85bdTA8 8247 Fix & normalize typing for chunks max-sixty 5635139 closed 0     0 2023-09-28T15:17:04Z 2023-09-28T16:47:02Z 2023-09-28T16:27:43Z MEMBER   0 pydata/xarray/pulls/8247

I noticed that "auto" wasn't allowed as a value in a dict. So this normalizes all chunk types, and defines the mapping as containing the inner type.

Allows removing some ignores (though also adds one).

One question — not necessary to answer now — is whether we should allow a tuple of definitions, for each dimension. Generally we use names, which helps prevent mistakes, and allows us to be less concerned about dimension ordering.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8247/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1902155047 PR_kwDOAMm_X85aonTY 8208 Use a bound `TypeVar` for `DataArray` and `Dataset` methods max-sixty 5635139 closed 0     4 2023-09-19T03:46:33Z 2023-09-28T16:46:54Z 2023-09-19T19:20:42Z MEMBER   1 pydata/xarray/pulls/8208
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

Edit: I added a comment outlining a problem with this

I think we should be using a TypeVar(..., bound=...) for our typing, since otherwise subtypes aren't allowed. I don't see a compelling reason to have all of T_DataWithCoords and T_DataArrayOrSet and T_Xarray, though I might be missing something.

So this unifies all T_DataWithCoords, T_DataArrayOrSet and T_Xarray to T_Xarray, and changes that type to be bound on a union of DataArray & Dataset (similar to the existing T_DataArrayOrSet). This covers the bulk of our API — functions which transform either a DataArray or Dataset and return the input type.

This does require some manual casts; I think because when there's a concrete path for both DataArray & Dataset, mypy doesn't unify them back together. It's also possible I'm missing something.

One alternative — a minor change — would be to bound on DataWithCoords, like the existing T_DataWithCoords, rather than the union. A quick comparison showed each required some additional casts / ignores over the other.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8208/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1899012398 PR_kwDOAMm_X85aeNYk 8191 Fix pytest markers max-sixty 5635139 closed 0     0 2023-09-15T20:02:52Z 2023-09-28T16:46:51Z 2023-09-15T20:27:38Z MEMBER   0 pydata/xarray/pulls/8191

My mistake from #8183. I added --strict-markers so we can't make this sort of mistake again.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8191/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1216641509 PR_kwDOAMm_X8421nGO 6519 Scale numfocus image in readme max-sixty 5635139 closed 0     0 2022-04-27T00:50:55Z 2023-09-28T16:46:42Z 2022-04-27T02:32:43Z MEMBER   0 pydata/xarray/pulls/6519   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6519/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
909729647 MDExOlB1bGxSZXF1ZXN0NjYwMjU5NDc2 5432 Attempt to improve canonical test ds max-sixty 5635139 closed 0     0 2021-06-02T17:35:41Z 2023-09-28T16:46:38Z 2023-09-28T16:46:37Z MEMBER   0 pydata/xarray/pulls/5432

As discussed in recent issues, I'm trying to create a canonical test ds that we can base most tests off. We used to do this more often, but it's less consistent now; and arguably the existing canonical ds could be improved.

The advantages of the "canonical ds" effort are that we can have a dataset for which operations should work — e.g. with encoding / attrs / dtypes / MultiIndexes / etc — without having to remember these for each operation, and there's a path to being able to abstract over backing stores, like we've started in test_dataarray.py.

But this became somewhat of a yak shave — now that dims are ordered, this affects test results. So I added the ability to change dimension order in transpose, but the existing dimension order was very specific by data variable, so still lots of tests break.

I'm pausing on this, but open to ideas. To handle the changing test results, I could move the "repr"-based tests to something like pytest-regtest (which I've used myself for a while and it's pretty good, though uses file snapshots rather than inline), or doctests (pytest-accept!); otherwise changing them is very manual.

Also open to feedback that this isn't somewhere to focus on consolidation, and letting tests evolve as they have been is more than fine.

  • [ ] Closes #xxxx
  • [ ] Tests added
  • [ ] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5432/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
967854972 MDExOlB1bGxSZXF1ZXN0NzEwMDA1NzY4 5694 Ask PRs to annotate tests max-sixty 5635139 closed 0     6 2021-08-12T02:19:28Z 2023-09-28T16:46:19Z 2023-06-19T05:46:36Z MEMBER   0 pydata/xarray/pulls/5694
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

As discussed https://github.com/pydata/xarray/pull/5690#issuecomment-897280353

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5694/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
430194200 MDExOlB1bGxSZXF1ZXN0MjY4MTM4OTg1 2875 DOC: More on pandas comparison max-sixty 5635139 closed 0     2 2019-04-07T21:24:44Z 2023-09-28T16:46:14Z 2023-09-28T16:46:14Z MEMBER   1 pydata/xarray/pulls/2875

Follow up from the mailing list: - Added some more thoughts on the multi-dimensional comparison. Some of this is opinionated (in concepts not arguments) so I'd appreciate feedback on both the concepts and language. - Removed some of the specific comparison with NDPanel etc, given those are removed - Placeholder for something on the Explicit API (wanted to get this version out, consistent with me leaving less work hanging)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2875/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1909747157 PR_kwDOAMm_X85bCPUt 8228 Remove an import fallback max-sixty 5635139 closed 0     1 2023-09-23T07:11:04Z 2023-09-28T16:46:03Z 2023-09-23T19:13:14Z MEMBER   0 pydata/xarray/pulls/8228

This is stable in 3.8, so we can remove the fallback now

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8228/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1903792930 PR_kwDOAMm_X85auJN5 8215 Use `TypeVar`s rather than specific unions max-sixty 5635139 closed 0     3 2023-09-19T22:06:13Z 2023-09-24T19:40:06Z 2023-09-24T19:40:05Z MEMBER   0 pydata/xarray/pulls/8215

Also from the chars of #8208 -- this uses the TypeVars we define, which hopefully sets a standard and removes ambiguity for how to type functions. It also allows subclasses.

Where possible, it uses T_Xarray, otherwise T_DataArrayOrSet where it's not possible for mypy to narrow the concrete type down.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8215/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1909746948 PR_kwDOAMm_X85bCPSS 8227 Add a `Literal` typing max-sixty 5635139 closed 0     0 2023-09-23T07:10:10Z 2023-09-23T19:40:57Z 2023-09-23T19:38:05Z MEMBER   0 pydata/xarray/pulls/8227   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8227/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1903880626 PR_kwDOAMm_X85aub-J 8216 Use `Self` rather than concrete types, remove `cast`s max-sixty 5635139 closed 0     0 2023-09-20T00:10:41Z 2023-09-21T01:53:44Z 2023-09-21T01:53:40Z MEMBER   0 pydata/xarray/pulls/8216

This should also allow for subtyping

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8216/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1904137707 PR_kwDOAMm_X85avTa9 8217 Convert `indexes.py` to use `Self` for typing max-sixty 5635139 closed 0     0 2023-09-20T05:00:31Z 2023-09-20T22:57:58Z 2023-09-20T22:57:53Z MEMBER   0 pydata/xarray/pulls/8217

I wanted to do this separately from #8216 , as it's the only one that adds a couple ignores. And given the ratio of impact-to-potential-merge-conflicts, I didn't want to slow the other PR down.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8217/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1905496592 PR_kwDOAMm_X85az6Gg 8219 Skip flaky test max-sixty 5635139 closed 0     0 2023-09-20T18:12:42Z 2023-09-20T19:57:20Z 2023-09-20T19:57:16Z MEMBER   0 pydata/xarray/pulls/8219
  • [x] Closes #4539
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8219/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1903471931 PR_kwDOAMm_X85atDTq 8212 Add comments on when to use which `TypeVar` max-sixty 5635139 closed 0     1 2023-09-19T17:53:03Z 2023-09-20T17:29:15Z 2023-09-20T08:23:23Z MEMBER   0 pydata/xarray/pulls/8212

From the chars of #8208

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8212/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1899893200 PR_kwDOAMm_X85ag6Ws 8198 Start a list of modules which require typing max-sixty 5635139 closed 0     0 2023-09-17T19:34:08Z 2023-09-20T09:39:28Z 2023-09-20T09:38:33Z MEMBER   0 pydata/xarray/pulls/8198

Notes inline. Just one module so far!

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8198/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1410336975 PR_kwDOAMm_X85A3d9c 7165 Fix warning in doctest max-sixty 5635139 closed 0     0 2022-10-16T01:13:21Z 2023-09-20T09:31:58Z 2022-10-16T01:37:13Z MEMBER   0 pydata/xarray/pulls/7165 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7165/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1410340285 PR_kwDOAMm_X85A3emZ 7166 Fix doctest warnings, enable errors in CI max-sixty 5635139 closed 0     4 2022-10-16T01:29:36Z 2023-09-20T09:31:58Z 2022-10-16T21:26:46Z MEMBER   0 pydata/xarray/pulls/7166

I'm not confident about the CI change; either we can merge with the "this is a trial message" and see how it goes, or split that into a separate PR and discuss.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7166/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1903479488 PR_kwDOAMm_X85atE7R 8213 Consolidate `T_DataArrayOrSet` max-sixty 5635139 closed 0     0 2023-09-19T17:58:59Z 2023-09-20T02:09:43Z 2023-09-20T02:09:39Z MEMBER   0 pydata/xarray/pulls/8213

I'm not confident this is a great idea — I think this doesn't allow subtyping in FacetGrid? It does consolidate one of the three definitions, making our typing simpler, which is a worthwhile goal. So posting for review.

From the chars of #8208

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8213/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1865945636 PR_kwDOAMm_X85YvIJ4 8114 Move `.rolling_exp` functions from `reduce` to `apply_ufunc` max-sixty 5635139 closed 0     10 2023-08-24T21:57:19Z 2023-09-19T01:13:27Z 2023-09-19T01:13:22Z MEMBER   0 pydata/xarray/pulls/8114
  • [x] Fixes #6870
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

A similar change should solve #6528, but let's get one finished first...

~Posting for discussion, will comment inline~ Ready for merge

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8114/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1899109828 PR_kwDOAMm_X85aeino 8193 Add some more mypy checks max-sixty 5635139 closed 0     7 2023-09-15T21:40:14Z 2023-09-17T19:34:55Z 2023-09-17T19:24:58Z MEMBER   0 pydata/xarray/pulls/8193

This disallows redundant casts

FWIW I thought we had gone through many of the tests and forced them to have typed defs, maybe with the intention of turning on some elements of strict mode. But then I don't think we have any strictness checks at the moment, and I see many functions in the tests which don't have typing. Am I mis-rembering?? Or maybe we started but didn't get far enough (it is a big project...)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8193/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1899020758 PR_kwDOAMm_X85aePOP 8192 Adjust ufunc error message max-sixty 5635139 closed 0     0 2023-09-15T20:10:31Z 2023-09-17T08:20:34Z 2023-09-17T08:20:31Z MEMBER   0 pydata/xarray/pulls/8192

Based on the correct observation in https://github.com/pydata/xarray/pull/8179#discussion_r1327429229 (slightly adjusted message)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8192/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1878099779 PR_kwDOAMm_X85ZYBES 8138 Allow `apply_ufunc` to ignore missing core dims max-sixty 5635139 closed 0     4 2023-09-01T22:09:20Z 2023-09-17T08:20:19Z 2023-09-17T08:20:13Z MEMBER   0 pydata/xarray/pulls/8138
  • [x] Closes #6391
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst

This probably needs a review and another turn, maybe some more tests on multiple objects etc. There are a couple of questions inline.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8138/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1899584022 PR_kwDOAMm_X85af_67 8196 Remove `requirements.txt` max-sixty 5635139 closed 0     0 2023-09-16T22:22:41Z 2023-09-17T07:03:02Z 2023-09-17T07:02:57Z MEMBER   0 pydata/xarray/pulls/8196 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8196/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1897096472 PR_kwDOAMm_X85aXwKH 8183 Remove `setup.cfg` in favor of `pyproject.toml` max-sixty 5635139 closed 0     9 2023-09-14T18:29:16Z 2023-09-15T22:42:42Z 2023-09-14T20:52:39Z MEMBER   0 pydata/xarray/pulls/8183

This is tested, but much of it was me tweaking from an LLM's attempt at the translation, so there may be small issues that aren't picked up in tests (but should be very easy to fix if these come up)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8183/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1895224326 PR_kwDOAMm_X85aRb_8 8179 Display data returned in `apply_ufunc` error message max-sixty 5635139 closed 0     0 2023-09-13T20:33:28Z 2023-09-15T20:10:38Z 2023-09-14T20:06:16Z MEMBER   0 pydata/xarray/pulls/8179

This makes debugging much easier!

  • [x] Tests added
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8179/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1897294071 PR_kwDOAMm_X85aYaBM 8185 Fix comment alignment in `pyproject.toml` max-sixty 5635139 closed 0     0 2023-09-14T20:54:05Z 2023-09-14T20:54:56Z 2023-09-14T20:54:52Z MEMBER   0 pydata/xarray/pulls/8185

I wasn't sufficiently careful in #8181...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8185/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1895568528 PR_kwDOAMm_X85aSh-V 8181 Set dev version above released version max-sixty 5635139 closed 0     2 2023-09-14T02:56:26Z 2023-09-14T20:54:36Z 2023-09-14T20:47:08Z MEMBER   0 pydata/xarray/pulls/8181

Pandas asserts that the xarray version that's running is above 2022.; locally it was set to 999 which failed this. It only applies when developing locally.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8181/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1895576777 PR_kwDOAMm_X85aSjhh 8182 Fix `PeriodIndex` deprecation in xarray tests max-sixty 5635139 closed 0     0 2023-09-14T03:06:34Z 2023-09-14T20:47:29Z 2023-09-14T15:32:49Z MEMBER   0 pydata/xarray/pulls/8182

Silences a few warnings

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8182/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1884999689 PR_kwDOAMm_X85ZvD67 8156 Cut middle version from CI max-sixty 5635139 closed 0     3 2023-09-07T02:14:01Z 2023-09-07T23:19:04Z 2023-09-07T06:29:03Z MEMBER   0 pydata/xarray/pulls/8156

Testing for 3.10 seems fairly low value — is there a realistic case where 3.10 would fail but 3.9 & 3.11 would pass?

Merging this would cut the CI queue...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8156/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1884997150 PR_kwDOAMm_X85ZvDW7 8155 Fix mypy error max-sixty 5635139 closed 0     1 2023-09-07T02:11:44Z 2023-09-07T02:24:13Z 2023-09-07T02:22:40Z MEMBER   0 pydata/xarray/pulls/8155

I think this should make CI green. I'm not sure whether it's the best approach, but having the tests pass is arguably valuable.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8155/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1884975625 PR_kwDOAMm_X85Zu-sZ 8154 Fix mypy error max-sixty 5635139 closed 0     1 2023-09-07T01:49:14Z 2023-09-07T02:09:15Z 2023-09-07T02:09:12Z MEMBER   0 pydata/xarray/pulls/8154

I think this should make CI green. I'm not sure whether it's the best approach, but having the tests pass is arguably valuable.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8154/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Next page

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);