home / github

Menu
  • Search all tables
  • GraphQL API

issues

Table actions
  • GraphQL API for issues

5 rows where state = "closed", type = "pull" and user = 38358698 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 5 ✖

state 1

  • closed · 5 ✖

repo 1

  • xarray 5
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1160073438 PR_kwDOAMm_X84z-iqi 6334 In backends, support expressing a dimension's preferred chunk sizes as a tuple of integers stanwest 38358698 closed 0     5 2022-03-04T21:39:46Z 2022-04-08T17:18:50Z 2022-04-08T17:18:50Z CONTRIBUTOR   0 pydata/xarray/pulls/6334
  • [X] Closes #6333
  • [X] Tests added
  • [X] User visible changes (including notable bug fixes) are documented in whats-new.rst
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6334/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1159961396 PR_kwDOAMm_X84z-K39 6330 In documentation on adding a new backend, add missing import and tweak headings stanwest 38358698 closed 0     0 2022-03-04T19:13:30Z 2022-03-07T14:17:29Z 2022-03-07T13:13:50Z CONTRIBUTOR   0 pydata/xarray/pulls/6330

Adding the import resolves the following exception that sphinx-build raises when one builds only "doc/internals/how-to-add-new-backend.rst":

``` NameError Traceback (most recent call last) Input In [1], in <module> ----> 1 var = xr.Variable( 2 dims=("x",), data=np.arange(10.0), attrs={"scale_factor": 10, "add_offset": 2} 3 )

NameError: name 'xr' is not defined ```

While in the file, I revised headings to have only their first letter capitalized (except for case-sensitive code), which seems to be the majority convention in the documentation.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6330/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1124431593 PR_kwDOAMm_X84yGFBx 6237 Enable running sphinx-build on Windows stanwest 38358698 closed 0     7 2022-02-04T17:15:14Z 2022-03-04T19:15:42Z 2022-03-01T16:00:34Z CONTRIBUTOR   0 pydata/xarray/pulls/6237
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

This PR enables one to build the documentation on Windows by manually invoking sphinx-build.

The first commit enables sphinx to execute the "conf.py" file. Before the commit, sphinx complains:

Configuration error: There is a programmable error in your configuration file:

with the exception FileNotFoundError: [WinError 2] The system cannot find the file specified where it tries to invoke conda. On Windows, conda environments other than the base environment have "conda.bat" on their path rather than "conda.exe", and one must call subprocess.run with "conda.bat" instead of merely "conda". However, the CONDA_EXE environment variable correctly points to the executable and should do so across platforms; it requires conda version 4.5 or later for conda/conda#6923.

The second commit enables the build to tolerate exceptions when deleting temporary files and tells Git to ignore more such files. Without the commit, builds occasionally failed at the os.remove calls with exceptions such as PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'example.nc'.

Should "whats-new.rst" mention these changes, which are developer-visible but not user-visible?

I welcome any feedback.

Edit: Checked the "whats-new" task.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6237/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1158639113 PR_kwDOAMm_X84z5zPC 6326 Lengthen underline, correct spelling, and reword stanwest 38358698 closed 0     1 2022-03-03T16:40:55Z 2022-03-03T17:27:42Z 2022-03-03T17:01:15Z CONTRIBUTOR   0 pydata/xarray/pulls/6326

Lengthening the underline resolves the following warning from sphinx-build:

``` [...]\xarray\doc\whats-new.rst:20: WARNING: Title underline too short.

v2022.03.1 (unreleased)

```

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6326/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1150484906 PR_kwDOAMm_X84zd6WA 6305 On Windows, enable successful test of opening a dataset containing a cftime index stanwest 38358698 closed 0     3 2022-02-25T14:07:50Z 2022-02-28T16:06:33Z 2022-02-28T09:53:22Z CONTRIBUTOR   0 pydata/xarray/pulls/6305
  • [X] User visible changes (including notable bug fixes) are documented in whats-new.rst

Previously, on Windows, the subject test unnecessarily failed, and the temporary directory and file remained, because the scheduler in the outer context prevented deleting the temporary directory upon exiting the inner context of the latter.

Example failure (with short traceback):

``` ================================================ FAILURES ================================================= __________________________ test_open_mfdataset_can_open_files_with_cftime_index ___________________________ C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\shutil.py:616: in _rmtree_unsafe os.unlink(fullname) E PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\STAN~1.WES\\AppData\\Local\\Temp\\tmpdpdajrgc\\test.nc' During handling of the above exception, another exception occurred: C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\tempfile.py:802: in onerror _os.unlink(path) E PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\STAN~1.WES\\AppData\\Local\\Temp\\tmpdpdajrgc\\test.nc' During handling of the above exception, another exception occurred: C:\Users\stan.west\Documents\Repositories\xarray\xarray\tests\test_distributed.py:128: in test_open_mfdataset_can_open_files_with_cftime_index assert_identical(tf["test"], da) C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\tempfile.py:827: in __exit__ self.cleanup() C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\tempfile.py:831: in cleanup self._rmtree(self.name) C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\tempfile.py:813: in _rmtree _shutil.rmtree(name, onerror=onerror) C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\shutil.py:740: in rmtree return _rmtree_unsafe(path, onerror) C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\shutil.py:618: in _rmtree_unsafe onerror(os.unlink, fullname, sys.exc_info()) C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\tempfile.py:805: in onerror cls._rmtree(path) C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\tempfile.py:813: in _rmtree _shutil.rmtree(name, onerror=onerror) C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\shutil.py:740: in rmtree return _rmtree_unsafe(path, onerror) C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\shutil.py:599: in _rmtree_unsafe onerror(os.scandir, path, sys.exc_info()) C:\Users\stan.west\Programs\Miniconda3-64\envs\xarray-dev\lib\shutil.py:596: in _rmtree_unsafe with os.scandir(path) as scandir_it: E NotADirectoryError: [WinError 267] The directory name is invalid: 'C:\\Users\\STAN~1.WES\\AppData\\Local\\Temp\\tmpdpdajrgc\\test.nc' ========================================= short test summary info ========================================= FAILED xarray/tests/test_distributed.py::test_open_mfdataset_can_open_files_with_cftime_index - NotADirec... =========================================== 1 failed in 10.77s ============================================ ```

The first commit swaps the two contexts to resolve the issue. The second commit replaces the tempfile.TemporaryDirectory() context manager with pytest's tmp_path fixture, which slightly simplifies the test and relies on pytest to remove the directory on a subsequent invocation.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6305/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);
Powered by Datasette · Queries took 317.836ms · About: xarray-datasette