issues

Table actions

2 rows where repo = 13221727, type = "pull" and user = 28786187 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

state 2

type 1

  • pull · 2 ✖

repo 1

  • xarray · 2 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
2235746028 PR_kwDOAMm_X85sQRSg 8924 Keep attributes for "bounds" variables st-bender 28786187 open 0     0 2024-04-10T14:29:58Z 2024-04-11T14:09:48Z   CONTRIBUTOR   0 pydata/xarray/pulls/8924

Issue #2921 is about mismatching time units between a time variable and its "bounds" companion. However, #2965 does more than fixing #2921, it removes all double attributes from "bounds" variables which has the undesired side effect that there is currently no way to save them to netcdf with xarray. Since the mentioned link is a recommendation and not a hard requirement for CF compliance, these attributes should be left to the caller to prepare the dataset variables appropriately if required. Reduces the amount of surprise that attributes are not written to disk and fixes #8368.

  • [x] Closes #8368
  • [ ] Tests added (simple round trip test would be in issue #8368)
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst (not sure about "user visibility" here)
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8924/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
937336962 MDExOlB1bGxSZXF1ZXN0NjgzOTA5OTgw 5580 dataset `__repr__` updates st-bender 28786187 closed 0     8 2021-07-05T20:03:55Z 2021-08-21T22:51:16Z 2021-08-21T22:51:03Z CONTRIBUTOR   0 pydata/xarray/pulls/5580

After discussing the recent change in the dataset __repr__, this implements the compromise discussed in #5545. It keeps the dataset __repr__ short, tunable via xr.set_options(), and gives the full output via ds.coords, ds.data_vars, and ds.attrs.

Passes the (updated) testsuite (locally).

  • [x] Closes #5545
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5580/reactions",
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);