issues

Table actions

1 row where repo = 13221727, state = "closed" and user = 8161792 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

state 1

  • closed · 1 ✖

repo 1

  • xarray · 1 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
668905666 MDU6SXNzdWU2Njg5MDU2NjY= 4291 resample function gives 0s instead of NaNs xzenggit 8161792 closed 0     3 2020-07-30T15:59:32Z 2020-08-05T16:55:58Z 2020-08-05T16:55:58Z NONE      

What happened: When I use resample(time='1d').sum(dim='time') to resample a time series with NaNs, the resampled result gives me 0s instead of NaNs, while NaNs should be the correct answer.

What you expected to happen:

NaNs should be the correct answer.

Minimal Complete Verifiable Example:

```python import xarray as xr

dates = pd.date_range('20200101', '20200601', freq='h') data = np.linspace(0, 10, num=len(dates)) data[0:30*24] = np.nan

da = xr.DataArray(data, coords=[dates], dims='time') da.plot()

Instead of NaNs, the resampled time series in January 20202 give us 0s, which not right.

da.resample(time='1d', skipna=True).sum(dim='time', skipna=True).plot() ```

Anything else we need to know?:

Did I misunderstand something here? Thanks!

Environment: xarray - '0.15.1'

Output of <tt>xr.show_versions()</tt> xarray - '0.15.1' 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4291/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed xarray 13221727 issue

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);