issues

Table actions

2 rows where repo = 13221727, state = "closed" and user = 14276158 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

state 1

  • closed · 2 ✖

repo 1

  • xarray · 2 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1147894038 PR_kwDOAMm_X84zVXuC 6292 Amended docs on how to add a new backend lpilz 14276158 closed 0     1 2022-02-23T10:11:06Z 2022-02-23T17:54:53Z 2022-02-23T17:54:47Z CONTRIBUTOR   0 pydata/xarray/pulls/6292

When trying to install a new xarray backend with poetry, I noticed that it should be xarray.backends instead of xarray_backends.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6292/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1121761078 PR_kwDOAMm_X84x9VPA 6232 Amended docstring to reflect the actual behaviour of Dataset.map lpilz 14276158 closed 0     4 2022-02-02T10:39:30Z 2022-02-23T09:51:41Z 2022-02-23T09:51:27Z CONTRIBUTOR   0 pydata/xarray/pulls/6232

In MetPy/pull#2312, I noticed that the behavior of Dataset.map's kwarg keep_attrs was not in line with its docstring. This is because in xarray 0.16.2 (pydata/xarray#3595 & pydata/xarray#4195) this behavior was changed.

In short, keep_attrs=True now copies both, the Dataset's and the variables' attributes and adds them to the new objects - preventing any change to them by the mapped function. In contrast, keep_attrs= False discards the Dataset's attributes and does not touch the variables' attributes, enabling the mapped function to modify them.

Here, I propose an update to the keep_attrs docstring of Dataset.map which would more accurately reflect its current behavior. Please feel free to provide alternative formulations if you feel like this one misses the mark.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6232/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);