issues

Table actions

9 rows where comments = 9, type = "pull" and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

state 2

type 1

  • pull · 9 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1920361792 PR_kwDOAMm_X85bl988 8258 Add a `.drop_attrs` method max-sixty 5635139 open 0     9 2023-09-30T18:42:12Z 2024-02-09T18:49:22Z   MEMBER   0 pydata/xarray/pulls/8258

Part of #3891

~Do we think this is a good idea? I'll add docs & tests if so...~

Ready to go, just needs agreement on whether it's good

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8258/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1897096472 PR_kwDOAMm_X85aXwKH 8183 Remove `setup.cfg` in favor of `pyproject.toml` max-sixty 5635139 closed 0     9 2023-09-14T18:29:16Z 2023-09-15T22:42:42Z 2023-09-14T20:52:39Z MEMBER   0 pydata/xarray/pulls/8183

This is tested, but much of it was me tweaking from an LLM's attempt at the translation, so there may be small issues that aren't picked up in tests (but should be very easy to fix if these come up)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8183/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
936123457 MDExOlB1bGxSZXF1ZXN0NjgyOTI5NDA1 5569 Consolidate TypeVars in a single place max-sixty 5635139 closed 0     9 2021-07-03T00:01:09Z 2021-08-22T00:04:54Z 2021-08-21T23:38:14Z MEMBER   0 pydata/xarray/pulls/5569
  • [x] Passes pre-commit run --all-files

This consolidates the TypeVars into a single place, and merges VariableType and T_Variable.

I'm not 100% sure the interaction between the .pyi file and the new xarray.core.types is optimal. But it does seem to work. Feedback very welcome, as ever.

There's a note to rename T_DSorDA — what do people think? T_Data? It's kinda inscrutable atm.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5569/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
860909006 MDExOlB1bGxSZXF1ZXN0NjE3NjY2NzI0 5188 Replace raises_regex with pytest.raises max-sixty 5635139 closed 0     9 2021-04-19T05:26:23Z 2021-04-19T23:10:06Z 2021-04-19T23:10:03Z MEMBER   0 pydata/xarray/pulls/5188
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

Is there a reason we have our own raises_regex? This replaces it with the standard pytest check.

This is another regex special, so it misses multi-line statements. I can dust off the multi-line regex manual if this ends up working.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5188/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
681528611 MDExOlB1bGxSZXF1ZXN0NDY5OTA2MzQ3 4351 Allow cov & corr to handle missing values max-sixty 5635139 closed 0     9 2020-08-19T04:02:21Z 2020-08-30T11:36:38Z 2020-08-24T16:39:11Z MEMBER   0 pydata/xarray/pulls/4351
  • [x] Closes #4349
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

I'm not that excited about how this is tested, very open to alternatives. And the mechanics could take another set of eyes too.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4351/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
509486175 MDExOlB1bGxSZXF1ZXN0MzMwMDQxNjM2 3418 change ALL_DIMS to equal ellipsis max-sixty 5635139 closed 0     9 2019-10-19T17:46:55Z 2019-10-25T17:16:33Z 2019-10-25T15:15:47Z MEMBER   0 pydata/xarray/pulls/3418

This is a more drastic version of the suggested change, making xr.ALL_DIMS equal the ellipsis, ....

The only downside I can see is that printing xr.ALL_DIMS will print .... The upside is that we get compat 'for free'

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3418/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
309976469 MDExOlB1bGxSZXF1ZXN0MTc4NDk0ODMw 2031 Isin max-sixty 5635139 closed 0     9 2018-03-30T05:07:12Z 2018-04-04T03:52:21Z 2018-04-04T02:46:57Z MEMBER   0 pydata/xarray/pulls/2031
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

This is an initial implementation of isin. It works for DataArrays, but isn't yet implemented further.

I've been away from these sorts features for too long: Is there a canonical place to put these? What's the canonical approach to extending to datasets? I can see a few approaches in the code. 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2031/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
192702101 MDExOlB1bGxSZXF1ZXN0OTU5ODk3Mzc= 1145 Rolling count max-sixty 5635139 closed 0     9 2016-11-30T22:44:50Z 2017-06-26T18:43:06Z 2017-06-26T18:43:06Z MEMBER   0 pydata/xarray/pulls/1145 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1145/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
156072065 MDExOlB1bGxSZXF1ZXN0NzA5MzI2Mzc= 852 BUG: Stringify DS attrs in dir max-sixty 5635139 closed 0     9 2016-05-21T00:07:23Z 2016-08-10T01:15:31Z 2016-08-10T01:13:50Z MEMBER   0 pydata/xarray/pulls/852

Previously:

``` python In [21]: ds Out[21]: <xarray.Dataset> Dimensions: (abc: 3) Coordinates: * abc (abc) int64 0 1 2 Data variables: 0 (abc) float64 0.3168 0.1132 0.6664 1 (abc) float64 0.9799 0.9663 0.01084 2 (abc) float64 0.9171 0.6848 0.5028

In [22]: dir(ds)

TypeError Traceback (most recent call last) <ipython-input-22-fd55ce5c03db> in <module>() ----> 1 dir(ds)

/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/xarray/core/common.py in dir(self) 157 extra_attrs = [item for sublist in self._attr_sources 158 for item in sublist] --> 159 return sorted(set(dir(type(self)) + extra_attrs)) 160 161

TypeError: unorderable types: numpy.ndarray() > str() ```

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/852/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);