issues

Table actions

9 rows where comments = 3, type = "pull" and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: draft, created_at (date), updated_at (date), closed_at (date)

state 2

type 1

  • pull · 9 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
2047459696 PR_kwDOAMm_X85iTmr2 8559 Support non-str Hashables in DataArray headtr1ck 43316012 closed 0     3 2023-12-18T21:09:13Z 2024-01-14T20:38:59Z 2024-01-14T20:38:59Z COLLABORATOR   0 pydata/xarray/pulls/8559
  • [x] Closes #8546
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Probably we should add a whole bunch of tests for this. For now only testing the constructor.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8559/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1928972239 PR_kwDOAMm_X85cC_Wb 8276 Give NamedArray Generic dimension type headtr1ck 43316012 open 0     3 2023-10-05T20:02:56Z 2023-10-16T13:41:45Z   COLLABORATOR   1 pydata/xarray/pulls/8276
  • [x] Towards #8199
  • [ ] Tests added
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst

This aims at making the dimenion type a generic parameter. I thought I will start with NamedArray when testing this out because it is much less interconnected.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8276/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1615980379 PR_kwDOAMm_X85Lm7SK 7600 Enable blacks `skip_magic_trailing_comma` options headtr1ck 43316012 closed 0     3 2023-03-08T21:36:46Z 2023-03-09T20:41:21Z 2023-03-09T20:40:25Z COLLABORATOR   0 pydata/xarray/pulls/7600

This little config change will make black remove trailing commas when they are not necessary to fit something into a single line.

It is a pure design choice but personally I like the clean up it does when function signatures simplify (although this happens rarely with more and more type hints added).

I can understand that some people prefer the manual control over what is multiline and what is not. Feel free to vote on it :)

For me it adds cheap LOCs so it looks like I am working hard, haha.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7600/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1424707135 PR_kwDOAMm_X85Bnixp 7228 Raise TypeError if plotting empty data headtr1ck 43316012 closed 0     3 2022-10-26T21:19:30Z 2022-11-10T23:00:42Z 2022-10-28T16:44:31Z COLLABORATOR   0 pydata/xarray/pulls/7228
  • [x] Closes #7156
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7228/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1419882372 PR_kwDOAMm_X85BXXw0 7200 Backends descriptions headtr1ck 43316012 closed 0     3 2022-10-23T18:23:32Z 2022-10-26T19:45:15Z 2022-10-26T16:01:04Z COLLABORATOR   0 pydata/xarray/pulls/7200
  • [x] Closes #7049
  • [ ] Tests added
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7200/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1385143758 PR_kwDOAMm_X84_j6Bn 7080 Fix `utils.get_axis` with kwargs headtr1ck 43316012 closed 0     3 2022-09-25T19:50:15Z 2022-09-28T18:02:18Z 2022-09-28T17:11:16Z COLLABORATOR   0 pydata/xarray/pulls/7080
  • [x] Closes #7078
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~~New functions/methods are listed in api.rst~~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7080/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1368690120 PR_kwDOAMm_X84-uNM2 7017 Add Ellipsis typehints headtr1ck 43316012 closed 0     3 2022-09-10T17:53:26Z 2022-09-12T15:40:08Z 2022-09-11T13:40:07Z COLLABORATOR   0 pydata/xarray/pulls/7017

This PR adds an Ellipsis typehint to some functions.

Interestingly mypy did not complain at the tests before, I assume it is because "..." is Hashable or something like that?

I don't know what to do with reductions, since they also support ellipsis, but it is basically the same as using None. Therefore, I assume it is not necessary to expose this feature.

Did I miss any functions where ellipsis is supported? It is hard to look for "..."... xD

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7017/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1361262641 PR_kwDOAMm_X84-VY9P 6986 Remove some warnings in tests headtr1ck 43316012 closed 0     3 2022-09-04T21:58:57Z 2022-09-05T16:06:35Z 2022-09-05T10:52:45Z COLLABORATOR   0 pydata/xarray/pulls/6986

This PR tries to get rid of several warnings in the tests.

I could not get rid of RuntimeWarning: All-NaN slice encountered for tests with dask. Does anyone know why is that? pytest.mark.filterwarnings does not seem to capture them...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6986/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1268697316 PR_kwDOAMm_X845hhHE 6690 Fix Dataset.where with drop=True and mixed dims headtr1ck 43316012 closed 0     3 2022-06-12T20:47:05Z 2022-06-13T18:06:44Z 2022-06-12T22:06:51Z COLLABORATOR   0 pydata/xarray/pulls/6690
  • [x] Closes #6227
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6690/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);