issues

Table actions

11 rows where comments = 2, type = "pull" and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: draft, created_at (date), updated_at (date), closed_at (date)

state 2

type 1

  • pull · 11 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1503621596 PR_kwDOAMm_X85F0ZZm 7392 Support complex arrays in xr.corr headtr1ck 43316012 closed 0     2 2022-12-19T21:22:25Z 2023-03-02T20:22:54Z 2023-02-14T16:38:27Z COLLABORATOR   0 pydata/xarray/pulls/7392
  • [x] Closes #7340
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7392/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1446613571 PR_kwDOAMm_X85Cw17l 7283 Fix mypy 0.990 types headtr1ck 43316012 closed 0     2 2022-11-12T21:34:14Z 2022-11-18T15:42:37Z 2022-11-16T18:41:58Z COLLABORATOR   0 pydata/xarray/pulls/7283
  • [x] Related to #7270
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7283/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1442702272 PR_kwDOAMm_X85Cjnvl 7276 Import nc_time_axis when needed headtr1ck 43316012 closed 0     2 2022-11-09T20:24:45Z 2022-11-10T23:00:15Z 2022-11-10T21:45:27Z COLLABORATOR   0 pydata/xarray/pulls/7276
  • [x] Closes #7275
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7276/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1393443839 PR_kwDOAMm_X84__aKC 7112 Support of repr and deepcopy of recursive arrays headtr1ck 43316012 closed 0     2 2022-10-01T15:24:40Z 2022-10-07T11:10:32Z 2022-10-06T22:04:01Z COLLABORATOR   0 pydata/xarray/pulls/7112
  • [x] Closes #7111
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

xarray.testing.assert_identical and probably more do not work yet.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7112/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1393837094 PR_kwDOAMm_X85AAmD9 7114 Fix typing of backends headtr1ck 43316012 closed 0     2 2022-10-02T17:20:56Z 2022-10-06T21:33:39Z 2022-10-06T21:30:01Z COLLABORATOR   0 pydata/xarray/pulls/7114

While adding type hints to test_backends I noticed that the open_dataset method and the abstract BackendEntrypoint were missing stream types as inputs.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7114/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1395053809 PR_kwDOAMm_X85AEpA1 7117 Expermimental mypy plugin headtr1ck 43316012 open 0     2 2022-10-03T17:07:59Z 2022-10-03T18:53:10Z   COLLABORATOR   1 pydata/xarray/pulls/7117

I was playing around a bit with a mypy plugin and this was the best I could come up with. Unfortunately the mypy docu about the plugins is not very detailed...

This plugin makes mypy recognize the user defined accessors.

There is a quite severe bug in there (due to my lack of understanding of mypy internals probably) which makes it work only on the first run but when you change a line in your code and run mypy again it will crash... (you can delete the cache to make it work one more time again :)

Any chance that a mypy expert can figure this out? haha

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7117/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1362485455 PR_kwDOAMm_X84-Zfn0 6994 Even less warnings in tests headtr1ck 43316012 closed 0     2 2022-09-05T21:35:50Z 2022-09-10T09:02:46Z 2022-09-09T05:48:19Z COLLABORATOR   0 pydata/xarray/pulls/6994

This PR removes several warnings from the tests and improves their typing on the way.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6994/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1275262097 PR_kwDOAMm_X8453Zo1 6702 Typing of GroupBy & Co. headtr1ck 43316012 closed 0     2 2022-06-17T16:50:43Z 2022-07-03T13:32:30Z 2022-06-29T20:06:04Z COLLABORATOR   0 pydata/xarray/pulls/6702

This PR adds typing support for groupby, coarsen, rolling, weighted and resample.

There are several open points:

  1. Coarsen is missing type annotations for reductions like max, they get added dynamically.
  2. The Groupby group-key type is quite wide. Does anyone have any idea on how to type it correctly? For now it is still Any.
  3. Several function signatures were inconsistent between the DataArray and Dataset versions (looking at you: map). I took the freedom to align them (required for mypy), hopefully this does not break too much.
  4. I was moving the generation functions from DataWithCoords to DataArray and Dataset, which adds some copy-paste of code (I tried to keep it minimal) but was unavoidable for typing support. (Adds the bonus that the corresponding modules are now only imported when required).
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6702/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1278661854 PR_kwDOAMm_X846CnXr 6710 Expanduser (~) for open_dataset with dask headtr1ck 43316012 closed 0     2 2022-06-21T15:58:34Z 2022-06-26T08:08:04Z 2022-06-25T23:44:56Z COLLABORATOR   0 pydata/xarray/pulls/6710
  • [x] Closes #6707
  • [x] ~~Tests added~~
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

I don't really know how to test this... Is it ok to leave it untested?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6710/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1236316818 PR_kwDOAMm_X8431gAK 6611 {full,zeros,ones}_like typing headtr1ck 43316012 closed 0     2 2022-05-15T15:18:55Z 2022-05-16T18:10:05Z 2022-05-16T17:42:25Z COLLABORATOR   0 pydata/xarray/pulls/6611

(partial) typing for functions full_like, zeros_like, ones_like.

I could not figure out how to properly use TypeVars so many things are "hardcoded" with overloads.

I have added a DTypeLikeSave to npcompat, not sure that this file is supposed to be edited.

Problem1: TypeVar["T", Dataset, DataArray, Variable] can only be one of these three, but never with Union[Dataset, DataArray] which is used in several other places in xarray. Problem2: The official mypy support says: use TypeVar["T", bound=Union[Dataset, DataArray, Variable] but the the isinstance(obj, Dataset) could not be correctly resolved (is that a mypy issue?).

So if anyone can get it to work with TypeVars, feel free to change it. :)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6611/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1233058314 PR_kwDOAMm_X843rEkU 6593 Fix polyval overloads headtr1ck 43316012 closed 0     2 2022-05-11T18:54:54Z 2022-05-12T14:50:14Z 2022-05-11T19:42:41Z COLLABORATOR   0 pydata/xarray/pulls/6593

Attempt to fix the typing issues in xr.polyval.

Some problems are still occuring and require a type: ignore. They seem more like mypy issues to me.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6593/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);