issues

Table actions

3 rows where comments = 12, repo = 13221727 and user = 6213168 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 2

state 1

repo 1

  • xarray · 3 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
553518018 MDExOlB1bGxSZXF1ZXN0MzY1ODM1MjQ3 3714 setuptools-scm and one-liner setup.py crusaderky 6213168 closed 0     12 2020-01-22T12:46:43Z 2020-01-27T07:42:36Z 2020-01-22T15:40:34Z MEMBER   0 pydata/xarray/pulls/3714
  • Closes #3369
  • Replace versioneer with setuptools-scm
  • Replace setup.py with setup.cfg
  • Drop pytest-runner as instructed by deprecation notice on the project webpage
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3714/reactions",
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 2,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
481250429 MDU6SXNzdWU0ODEyNTA0Mjk= 3222 Minimum versions for optional libraries crusaderky 6213168 closed 0     12 2019-08-15T17:18:16Z 2019-10-08T21:23:47Z 2019-10-08T21:23:47Z MEMBER      

In CI there are:

  • tests for all the latest versions of all libraries, mandatory and optional (py36, py37, py37-windows)
  • tests for the minimum versions of the mandatory libraries only (py35-min)

There are no tests for legacy versions of the optional libraries.

Today I tried downgrading dask in the py37 environment to dask=1.1.2, which is 6 months old...

...it's a bloodbath. 383 errors of the most diverse kind.

In the codebase I found mentions to much older minimum versions: installing.rst mentions dask >=0.16.1, and Dataset.chunk() even asks for dask>=0.9.

It think we should add CI tests for old versions of the optional dependencies. What policy should we adopt when we find an incompatibility? How old a library should be not to bother fixing bugs and just require a newer version? I personally would go for an aggressive 6 months worth' of backwards compatibility; less if the time it takes to fix the issues is excessive. The tests should run on py36 because py35 builds are becoming very scarce in anaconda.

This has the outlook of being an exercise in extreme frustration. I'm afraid I personally hold zero interest towards packages older than the latest available in the anaconda official repo, so I'm not volunteering for this one (sorry).

I'd like to hear other people's opinions and/or offers of self-immolation... :)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3222/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed xarray 13221727 issue
430214243 MDExOlB1bGxSZXF1ZXN0MjY4MTUyODIw 2877 WIP: type annotations crusaderky 6213168 closed 0     12 2019-04-08T00:55:31Z 2019-04-24T14:54:07Z 2019-04-10T18:41:50Z MEMBER   0 pydata/xarray/pulls/2877

Fixes #2869

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2877/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);